chore(git): merge pull request 'fix: disable body scroll on popup open' (#88) from 61-popup-scroll into staging
All checks were successful
Release to Staging / build_and_release (push) Successful in 44s

Reviewed-on: #88
This commit is contained in:
enes 2024-10-21 09:49:13 +00:00
commit 04f32546f2
7 changed files with 60 additions and 4 deletions

View File

@ -5,7 +5,12 @@ import { useState } from 'react'
import { Link } from 'react-router-dom' import { Link } from 'react-router-dom'
import { toast } from 'react-toastify' import { toast } from 'react-toastify'
import { RelayController, UserRelaysType } from '../controllers' import { RelayController, UserRelaysType } from '../controllers'
import { useAppSelector, useDidMount, useNDKContext } from '../hooks' import {
useAppSelector,
useBodyScrollDisable,
useDidMount,
useNDKContext
} from '../hooks'
import { appRoutes, getProfilePageRoute } from '../routes' import { appRoutes, getProfilePageRoute } from '../routes'
import '../styles/author.css' import '../styles/author.css'
import '../styles/innerPage.css' import '../styles/innerPage.css'
@ -254,6 +259,8 @@ export const ProfileQRButtonWithPopUp = ({
}: QRButtonWithPopUpProps) => { }: QRButtonWithPopUpProps) => {
const [isOpen, setIsOpen] = useState(false) const [isOpen, setIsOpen] = useState(false)
useBodyScrollDisable(isOpen)
const nprofile = nip19.nprofileEncode({ const nprofile = nip19.nprofileEncode({
pubkey pubkey
}) })
@ -335,6 +342,8 @@ type ZapButtonWithPopUpProps = {
const ZapButtonWithPopUp = ({ pubkey }: ZapButtonWithPopUpProps) => { const ZapButtonWithPopUp = ({ pubkey }: ZapButtonWithPopUpProps) => {
const [isOpen, setIsOpen] = useState(false) const [isOpen, setIsOpen] = useState(false)
useBodyScrollDisable(isOpen)
return ( return (
<> <>
<div <div

View File

@ -6,3 +6,4 @@ export * from './useMuteLists'
export * from './useNSFWList' export * from './useNSFWList'
export * from './useReactions' export * from './useReactions'
export * from './useNDKContext' export * from './useNDKContext'
export * from './useScrollDisable'

View File

@ -0,0 +1,11 @@
import { useEffect } from 'react'
export const useBodyScrollDisable = (disable: boolean) => {
useEffect(() => {
if (disable) document.body.style.overflow = 'hidden'
return () => {
document.body.style.overflow = ''
}
}, [disable])
}

View File

@ -10,6 +10,7 @@ import { MetadataController } from '../controllers'
import { import {
useAppDispatch, useAppDispatch,
useAppSelector, useAppSelector,
useBodyScrollDisable,
useDidMount, useDidMount,
useNDKContext useNDKContext
} from '../hooks' } from '../hooks'
@ -27,6 +28,18 @@ export const Header = () => {
const { findMetadata } = useNDKContext() const { findMetadata } = useNDKContext()
const userState = useAppSelector((state) => state.user) const userState = useAppSelector((state) => state.user)
// Track nostr-login extension modal open state
const [isOpen, setIsOpen] = useState(false)
const handleOpen = () => setIsOpen(true)
const handleClose = () => setIsOpen(false)
useEffect(() => {
window.addEventListener('nlCloseModal', handleClose)
return () => {
window.removeEventListener('nlCloseModal', handleClose)
}
}, [])
useBodyScrollDisable(isOpen)
useEffect(() => { useEffect(() => {
initNostrLogin({ initNostrLogin({
darkMode: true, darkMode: true,
@ -66,6 +79,7 @@ export const Header = () => {
}, [dispatch, findMetadata]) }, [dispatch, findMetadata])
const handleLogin = () => { const handleLogin = () => {
handleOpen()
launchNostrLoginDialog() launchNostrLoginDialog()
} }
@ -260,6 +274,8 @@ const TipButtonWithDialog = React.memo(() => {
const [adminNpub, setAdminNpub] = useState<string | null>(null) const [adminNpub, setAdminNpub] = useState<string | null>(null)
const [isOpen, setIsOpen] = useState(false) const [isOpen, setIsOpen] = useState(false)
useBodyScrollDisable(isOpen)
useDidMount(async () => { useDidMount(async () => {
const metadataController = await MetadataController.getInstance() const metadataController = await MetadataController.getInstance()
setAdminNpub(metadataController.adminNpubs[0]) setAdminNpub(metadataController.adminNpubs[0])
@ -321,6 +337,8 @@ const TipButtonWithDialog = React.memo(() => {
const RegisterButtonWithDialog = () => { const RegisterButtonWithDialog = () => {
const [showPopUp, setShowPopUp] = useState(false) const [showPopUp, setShowPopUp] = useState(false)
useBodyScrollDisable(showPopUp)
return ( return (
<> <>
<a <a

View File

@ -12,7 +12,12 @@ import { BlogCard } from '../../components/BlogCard'
import { LoadingSpinner } from '../../components/LoadingSpinner' import { LoadingSpinner } from '../../components/LoadingSpinner'
import { ProfileSection } from '../../components/ProfileSection' import { ProfileSection } from '../../components/ProfileSection'
import { MetadataController, UserRelaysType } from '../../controllers' import { MetadataController, UserRelaysType } from '../../controllers'
import { useAppSelector, useDidMount, useNDKContext } from '../../hooks' import {
useAppSelector,
useBodyScrollDisable,
useDidMount,
useNDKContext
} from '../../hooks'
import { getGamePageRoute, getModsEditPageRoute } from '../../routes' import { getGamePageRoute, getModsEditPageRoute } from '../../routes'
import '../../styles/comments.css' import '../../styles/comments.css'
import '../../styles/downloads.css' import '../../styles/downloads.css'
@ -221,6 +226,8 @@ const Game = ({ naddr, game, author, aTag }: GameProps) => {
const [isBlocked, setIsBlocked] = useState(false) const [isBlocked, setIsBlocked] = useState(false)
const [isAddedToNSFW, setIsAddedToNSFW] = useState(false) const [isAddedToNSFW, setIsAddedToNSFW] = useState(false)
useBodyScrollDisable(showReportPopUp)
useEffect(() => { useEffect(() => {
if (userState.auth && userState.user?.pubkey) { if (userState.auth && userState.user?.pubkey) {
const pubkey = userState.user.pubkey as string const pubkey = userState.user.pubkey as string

View File

@ -5,7 +5,13 @@ import {
UserRelaysType UserRelaysType
} from 'controllers' } from 'controllers'
import { formatDate } from 'date-fns' import { formatDate } from 'date-fns'
import { useAppSelector, useDidMount, useNDKContext, useReactions } from 'hooks' import {
useAppSelector,
useBodyScrollDisable,
useDidMount,
useNDKContext,
useReactions
} from 'hooks'
import { useComments } from 'hooks/useComments' import { useComments } from 'hooks/useComments'
import { Event, kinds, nip19, UnsignedEvent } from 'nostr-tools' import { Event, kinds, nip19, UnsignedEvent } from 'nostr-tools'
import React, { import React, {
@ -502,6 +508,8 @@ const Zap = (props: Event) => {
const [totalZappedAmount, setTotalZappedAmount] = useState(0) const [totalZappedAmount, setTotalZappedAmount] = useState(0)
useBodyScrollDisable(isOpen)
useDidMount(() => { useDidMount(() => {
RelayController.getInstance() RelayController.getInstance()
.getTotalZapAmount( .getTotalZapAmount(

View File

@ -1,6 +1,6 @@
import { ZapSplit } from 'components/Zap' import { ZapSplit } from 'components/Zap'
import { RelayController } from 'controllers' import { RelayController } from 'controllers'
import { useAppSelector, useDidMount } from 'hooks' import { useAppSelector, useBodyScrollDisable, useDidMount } from 'hooks'
import { useState } from 'react' import { useState } from 'react'
import { toast } from 'react-toastify' import { toast } from 'react-toastify'
import { ModDetails } from 'types' import { ModDetails } from 'types'
@ -18,6 +18,8 @@ export const Zap = ({ modDetails }: ZapProps) => {
const [totalZappedAmount, setTotalZappedAmount] = useState(0) const [totalZappedAmount, setTotalZappedAmount] = useState(0)
useBodyScrollDisable(isOpen)
useDidMount(() => { useDidMount(() => {
RelayController.getInstance() RelayController.getInstance()
.getTotalZapAmount( .getTotalZapAmount(