Resolve naddr encoding on mods #230

New Issue

enes · 2025-02-20T14:36:07Z

enes commented

2025-02-20 14:36:07 +00:00

Reply system uses standardised implementation of the naddr encoding (from the ndk) while the mods implementation swaps one of the values which now breaks the link to the direct mod comment.

Based on the 93d9a12f16/19.md

for naddr, it is the identifier (the "d" tag) of the event being referenced
We are using the whole "a" tag.

 const naddr = nip19.naddrEncode({
            identifier: aTag,
            pubkey: signedEvent.pubkey,
            kind: signedEvent.kind,
            relays: publishedOnRelays
          })

Reply system uses standardised implementation of the `naddr` encoding (from the `ndk`) while the mods implementation swaps one of the values which now breaks the link to the direct mod comment. Based on the https://github.com/nostr-protocol/nips/blob/93d9a12f1693582b1a6231f8fe3e3832ba4fa8b3/19.md >for naddr, it is the identifier (the "d" tag) of the event being referenced We are using the whole "a" tag. ```ts const naddr = nip19.naddrEncode({ identifier: aTag, pubkey: signedEvent.pubkey, kind: signedEvent.kind, relays: publishedOnRelays }) ```

enes added this to the Issues project 2025-02-20 14:36:07 +00:00

freakoverse moved this to To Do in Issues on 2025-02-22 20:48:53 +00:00

freakoverse commented

2025-02-24 10:21:48 +00:00

enes paraphrasing:
so turns out there wasn't an issue here necessarily, it's just that we've moved forward with an implementations that others aren't moving forward with (a tag and e tag differences), in regards to finding the main post from a comment, where it's a matter of other clients supporting such a method to properly render the main post from an attached comment.

freak:
with that said, while we do heavily lean towards being interoperable with clients / with a standard, it's not an absolute, and this one can be skipped/ignored.

enes paraphrasing: so turns out there wasn't an issue here necessarily, it's just that we've moved forward with an implementations that others aren't moving forward with (a tag and e tag differences), in regards to finding the main post from a comment, where it's a matter of other clients supporting such a method to properly render the main post from an attached comment. freak: with that said, while we do heavily lean towards being interoperable with clients / with a standard, it's not an absolute, and this one can be skipped/ignored.

freakoverse added the

Priority

Low

label 2025-02-24 10:22:04 +00:00

freakoverse moved this to Archive in Issues on 2025-02-24 10:22:12 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: degmods/degmods.com#230