freakoverse/Third_Party_Issues
0
0
Code Issues 7 Packages Projects 1 Wiki

NDKRelaySet.fromRelayUrls() function accepts the empty arrays for relayUrls #1

New Issue
Open
opened 2024-11-27 10:54:27 +00:00 by freakoverse · 0 comments
freakoverse commented 2024-11-27 10:54:27 +00:00
Owner
Copy Link

Enes: heads up for people using ndk util function NDKRelaySet.fromRelayUrls() function accepts the empty arrays for relayUrls and contrary to what I believed it actually creates the NDKRelaySet with no relays succesfully, and accepts it as "valid" down the line in code where ndk treats it as such, basically the fallbacks that would flip on undefined relay set are ignored and requests would fail

Enes: heads up for people using ndk util function NDKRelaySet.fromRelayUrls() function accepts the empty arrays for relayUrls and contrary to what I believed it actually creates the NDKRelaySet with no relays succesfully, and accepts it as "valid" down the line in code where ndk treats it as such, basically the fallbacks that would flip on undefined relay set are ignored and requests would fail
freakoverse added the
Kind/Bug
 label 2024-11-27 10:54:27 +00:00
freakoverse added this to the (deleted) project 2024-11-27 10:54:27 +00:00
freakoverse added the
Project
NDK
 label 2024-11-27 11:16:56 +00:00
freakoverse modified the project from (deleted) to General 2024-11-27 13:11:17 +00:00
enes moved this to Bugs in General on 2025-01-27 13:05:34 +00:00
enes moved this to Bugs in General on 2025-02-03 17:29:09 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Project
Blossom
Project
BTCPS
Bitcoin Pay Server
Project
LDK
Lightning Development Kit
Project
Nostr (NIPs)
Project
nostr-tools
Project
NDK
Nostr Development Kit
Project
nostr-login
https://github.com/nostrband/nostr-login
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Kind/Bug
Project
NDK
Milestone
No items
No Milestone
Projects
Clear projects
No project General
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: freakoverse/Third_Party_Issues#1
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?