ndk serializer #7

New Issue

enes · 2024-11-28T12:39:57Z

enes commented

2024-11-28 12:39:57 +00:00

Serialize and deserialize have optional includeSig or includeId and it's unclear how it's used (called from other code) and what happens when both are set true or false, or only includeSig set true.

The serializer creates an array which has item order depending on the flags and when deserializing, depending on the flags, order would not be the same.

6b3ea8b298/ndk/src/events/serializer.ts (L13)

Serialize and deserialize have optional `includeSig` or `includeId` and it's unclear how it's used (called from other code) and what happens when both are set true or false, or only includeSig set `true`. The serializer creates an array which has item order depending on the flags and when deserializing, depending on the flags, order would not be the same. https://github.com/nostr-dev-kit/ndk/blob/6b3ea8b298680bee654ba87107da09bc5a63cb54/ndk/src/events/serializer.ts#L13

enes added the

labels 2024-11-28 12:39:57 +00:00

enes added this to the General project 2024-11-28 12:39:57 +00:00

Sign in to join this conversation.