qtime

0 Followers · 0 Following

• Joined on 2025-03-25

Repositories Projects Packages Public Activity Starred Repositories

52 contributions in the last 12 months

Less

More

qtime created pull request voca/voca#24 2025-05-10 10:53:33 +00:00

Refactor TTS module and restructure package hierarchy

qtime created pull request voca/voca#23 2025-05-10 10:52:46 +00:00

refactoring/simplify-mainviewmodel

qtime created pull request voca/voca#22 2025-05-10 10:52:08 +00:00

refactoring/simplify-mainviewmodel

qtime pushed to refactoring/package-structure-update at voca/voca 2025-05-10 10:50:21 +00:00

c2ef238047 Refactor TTS module and restructure package hierarchy

qtime created branch refactoring/package-structure-update in voca/voca 2025-05-10 10:50:21 +00:00

qtime pushed to refactoring/deps-and-navigation at voca/voca 2025-05-10 10:50:10 +00:00

qtime created branch refactoring/deps-and-navigation in voca/voca 2025-05-10 10:50:10 +00:00

qtime pushed to refactoring/simplify-mainviewmodel at voca/voca 2025-05-10 10:50:03 +00:00

ca83698cd3 Refactor TTS management to use TTSManager interface

da6156b6d8 Refactor audio playback with Mp3AudioManager integration

8badc45601 Refactor navigation to use typed routes with sealed classes

bc6457996c Simplify project structure and dependencies

ecc430ed9e Refactor theme colors into a separate Color.kt file

Compare 5 commits »

qtime created branch refactoring/simplify-mainviewmodel in voca/voca 2025-05-10 10:50:03 +00:00

qtime commented on pull request voca/voca#19 2025-05-10 06:51:09 +00:00

fix-tts-foreground

pendingStartSentenceIndex is also a mutable property that lives outside this function. Best to also take a snapshot of it rather than using it directly inside the coroutine. This will help avoid nasty race conditions when working with such mutable state.

qtime commented on pull request voca/voca#19 2025-05-10 06:51:09 +00:00

fix-tts-foreground

This can then be removed

qtime commented on pull request voca/voca#19 2025-05-10 06:51:09 +00:00

fix-tts-foreground

Too much logic inside one method:

qtime commented on pull request voca/voca#19 2025-05-10 06:51:09 +00:00

fix-tts-foreground

Your coroutine will silently fail if anything in SentenceParser.parse() or the playback process throws.

qtime commented on pull request voca/voca#19 2025-05-10 06:51:09 +00:00

fix-tts-foreground

In my opinion, committing commented-out code is a code smell, unless there’s a truly compelling reason—though in my experience, those are rare.

qtime created pull request voca/voca#18 2025-04-28 06:00:04 +00:00

Refactor MainScreen and dependency injection modules

qtime pushed to feedback/main-28-04-25 at voca/voca 2025-04-28 05:59:26 +00:00

58dd797dc6 Refactor MainScreen and dependency injection modules

qtime created branch feedback/main-28-04-25 in voca/voca 2025-04-28 05:59:26 +00:00

qtime deleted branch feedback/main-28-04-25 from voca/voca 2025-04-28 05:58:31 +00:00

qtime pushed to feedback/main-28-04-25 at voca/voca 2025-04-28 05:57:08 +00:00

58dd797dc6 Refactor MainScreen and dependency injection modules

qtime created branch feedback/main-28-04-25 in voca/voca 2025-04-28 05:57:08 +00:00