From 61f39d17ff4619c2b6beedf7d3189c03278aeede Mon Sep 17 00:00:00 2001
From: enes <mulahasanovic@outlook.com>
Date: Tue, 20 Aug 2024 14:38:03 +0200
Subject: [PATCH] fix(lint): add deps, remove any, update warning limit

---
 package.json                            |  2 +-
 src/pages/sign/index.tsx                |  6 ++++--
 src/pages/sign/internal/displayMeta.tsx |  2 +-
 src/types/errors/DecryptionError.ts     | 24 ++++++++++++++++--------
 src/utils/zip.ts                        |  6 ++++--
 5 files changed, 26 insertions(+), 14 deletions(-)

diff --git a/package.json b/package.json
index f1c513c..758d63d 100644
--- a/package.json
+++ b/package.json
@@ -7,7 +7,7 @@
   "scripts": {
     "dev": "vite",
     "build": "tsc && vite build",
-    "lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 10",
+    "lint": "eslint . --ext ts,tsx --report-unused-disable-directives --max-warnings 6",
     "lint:fix": "eslint . --fix --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
     "lint:staged": "eslint --fix --ext ts,tsx --report-unused-disable-directives --max-warnings 0",
     "formatter:check": "prettier --check \"src/**/*.{ts,tsx,js,jsx,html,css,sass,less,yml,md,graphql}\"",
diff --git a/src/pages/sign/index.tsx b/src/pages/sign/index.tsx
index a762292..be755f4 100644
--- a/src/pages/sign/index.tsx
+++ b/src/pages/sign/index.tsx
@@ -236,9 +236,11 @@ export const SignPage = () => {
       if (!arrayBuffer) return
       const blob = new Blob([arrayBuffer])
       saveAs(blob, `exported-${unixNow()}.sigit.zip`)
-    } catch (error: any) {
+    } catch (error) {
       console.log('error in zip:>> ', error)
-      toast.error(error.message || 'Error occurred in generating zip file')
+      if (error instanceof Error) {
+        toast.error(error.message || 'Error occurred in generating zip file')
+      }
     }
   }
 
diff --git a/src/pages/sign/internal/displayMeta.tsx b/src/pages/sign/internal/displayMeta.tsx
index fbc9264..03ba364 100644
--- a/src/pages/sign/internal/displayMeta.tsx
+++ b/src/pages/sign/internal/displayMeta.tsx
@@ -141,7 +141,7 @@ export const DisplayMeta = ({
           })
       }
     })
-  }, [users, submittedBy])
+  }, [users, submittedBy, metadata])
 
   const downloadFile = async (filename: string) => {
     const arrayBuffer = await files[filename].file.arrayBuffer()
diff --git a/src/types/errors/DecryptionError.ts b/src/types/errors/DecryptionError.ts
index 6a174b8..7014ab8 100644
--- a/src/types/errors/DecryptionError.ts
+++ b/src/types/errors/DecryptionError.ts
@@ -1,18 +1,26 @@
 export class DecryptionError extends Error {
   public message: string = ''
 
-  constructor(public inputError: any) {
+  constructor(public inputError: unknown) {
     super()
 
-    if (inputError.message.toLowerCase().includes('expected')) {
-      this.message = `The decryption key length or format is invalid.`
-    } else if (
-      inputError.message.includes('The JWK "alg" member was inconsistent')
-    ) {
-      this.message = `The decryption key is invalid.`
+    // Make sure inputError has access to the .message
+    if (inputError instanceof Error) {
+      if (inputError.message.toLowerCase().includes('expected')) {
+        this.message = `The decryption key length or format is invalid.`
+      } else if (
+        inputError.message.includes('The JWK "alg" member was inconsistent')
+      ) {
+        this.message = `The decryption key is invalid.`
+      } else {
+        this.message =
+          inputError.message || 'An error occurred while decrypting file.'
+      }
     } else {
+      // We don't have message on the inputError
+      // Stringify whole error and set that as a message
       this.message =
-        inputError.message || 'An error occurred while decrypting file.'
+        JSON.stringify(inputError) || 'An error occurred while decrypting file.'
     }
 
     this.name = 'DecryptionError'
diff --git a/src/utils/zip.ts b/src/utils/zip.ts
index 7a7a49f..577dd86 100644
--- a/src/utils/zip.ts
+++ b/src/utils/zip.ts
@@ -37,9 +37,11 @@ const readContentOfZipEntry = async <T extends OutputType>(
 const loadZip = async (data: InputFileFormat): Promise<JSZip | null> => {
   try {
     return await JSZip.loadAsync(data)
-  } catch (err: any) {
+  } catch (err) {
     console.log('err in loading zip file :>> ', err)
-    toast.error(err.message || 'An error occurred in loading zip file.')
+    if (err instanceof Error) {
+      toast.error(err.message || 'An error occurred in loading zip file.')
+    }
     return null
   }
 }