sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

In offline mode create a wrapper zip file #110

Merged
s merged 8 commits from issue-109 into staging 2024-06-13 10:01:31 +00:00
Conversation 1 Commits 8 Files Changed 7 +1246 -714
s commented 2024-06-13 06:50:44 +00:00
Owner
Copy Link

Issue

closes #109

Intent

  • navigate to different pages based on uploaded file
  • in offline mode create a wrapper zip file for sigit which should have keys.json and a sigit file
### Issue closes #109 ### Intent * navigate to different pages based on uploaded file * in offline mode create a wrapper zip file for sigit which should have keys.json and a sigit file
s added 7 commits 2024-06-13 06:50:44 +00:00
y requested changes 2024-06-13 09:37:49 +00:00
y left a comment
Owner
Copy Link

overall PR looks good, just please add more comments

overall PR looks good, just please add more comments
src/controllers/NostrController.ts Outdated
@ -378,6 +378,54 @@ export class NostrController extends EventEmitter {
throw new Error('Login method is undefined')
}
nip04Decrypt = async (sender: string, content: string) => {
y commented 2024-06-13 09:23:42 +00:00
Owner
Copy Link

pls add comments

pls add comments
s marked this conversation as resolved
src/pages/sign/internal/displayMeta.tsx
@ -0,0 +1,426 @@
import JSZip from 'jszip'
y commented 2024-06-13 09:37:01 +00:00
Owner
Copy Link

pls add more comments

pls add more comments
s marked this conversation as resolved
s added 1 commit 2024-06-13 09:59:02 +00:00
s merged commit d737f4891f into staging 2024-06-13 10:01:31 +00:00
s deleted branch issue-109 2024-06-13 10:01:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
y
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#110
No description provided.
Delete Branch "issue-109"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?