sigit/sigit.io
7
2
Fork 0
Code Issues 51 Pull Requests 3 Actions Packages Projects 1 Releases Wiki Activity

Login Page - login with pubkey hex #144

New Issue
Closed
opened 2024-08-15 13:10:14 +00:00 by enes · 3 comments
enes commented 2024-08-15 13:10:14 +00:00
Member
Copy Link

Nostr login page allows us to login with pubkey hex value (not explicitly written in the label). The app proceeds but the npub shown for the profile after the login doesn't match the values seen in online converts (nostrcheck.me, https://nostrtool.com/)

Nostr login page allows us to login with pubkey hex value (not explicitly written in the label). The app proceeds but the npub shown for the profile after the login doesn't match the values seen in online converts (nostrcheck.me, https://nostrtool.com/)
enes added the
Kind/Bug
Status
Need More Info
 labels 2024-08-15 13:10:14 +00:00
s commented 2024-08-19 07:43:14 +00:00
Owner
Copy Link

Hex string is being treated as private key, see

If its confusing we can disable hex input.

Hex string is being treated as private key, [see](https://git.nostrdev.com/sigit/sigit.io/blame/commit/b8ba8d0ab49ee26eda25824361fde72974da84af/src/pages/nostr/index.tsx#L330) If its confusing we can disable hex input.
b commented 2024-08-19 07:59:03 +00:00
Owner
Copy Link

Logging in with public key should definitely be disabled, there's no use case where we should allow anyone to attempt to see other people's sigits (it's impossible anyway)

Logging in with public key should definitely be disabled, there's no use case where we should allow anyone to attempt to see other people's sigits (it's impossible anyway)
enes commented 2024-10-09 10:08:29 +00:00
Author
Member
Copy Link

After nostr-login package update #217, the private key login is now only available with ?nsec= search param for local development only (preferably with dummy accounts). We've kept the hex key form option as well.

After `nostr-login` package update https://git.nostrdev.com/sigit/sigit.io/pulls/217, the private key login is now only available with `?nsec=` search param for local development only (preferably with dummy accounts). We've kept the hex key form option as well.
enes closed this issue 2024-10-09 10:08:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sigit/sigit.io#144
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?