sigit/sigit.io
6
2
Fork 0
Code Issues 41 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

feat: implemented relay controller and use that for fetching and publishing events #149

Merged
s merged 10 commits from relay-controller into staging 2024-08-20 12:13:23 +00:00
Conversation 1 Commits 10 Files Changed 20 +1124 -1051
s commented 2024-08-15 17:14:28 +00:00
Owner
Copy Link
  • Implemented relay controller
  • Refactor code in relay setting page
  • Move dvm related operations from controllers to a separate dvm file in utils folder
  • removed connection status state from redux store
* Implemented relay controller * Refactor code in relay setting page * Move dvm related operations from controllers to a separate dvm file in utils folder * removed connection status state from redux store
s added 1 commit 2024-08-15 17:14:28 +00:00
feat: implemented relay controller and use that for fetching and publishing events
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
a775d7b265
s added 2 commits 2024-08-18 17:49:02 +00:00
chore(refactor): move dvm related function to dvm utils file and relay related to relays utils file
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
66c7182fa4
s added 1 commit 2024-08-18 17:55:24 +00:00
chore: remove relay connection status from redux
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
12765cf758
s changed title from WIP: feat: implemented relay controller and use that for fetching and publishing events to feat: implemented relay controller and use that for fetching and publishing events 2024-08-19 05:54:49 +00:00
enes reviewed 2024-08-19 10:38:43 +00:00
enes left a comment
Member
Copy Link

On the login I can see the following error/warning in the console, but I can't replicate it each time (sent the screenshot) but I've only seen it now on relay-controller branch (also happened on logout click during the call and it prevented the logout, but unable to replicate).

Error: A state mutation was detected between dispatches, in the path 'relays.mostPopular.30'.  This may cause incorrect behavior. (https://redux.js.org/style-guide/style-guide#do-not-mutate-state)
    at immutableStateInvariantMiddleware.ts:200:19
    at Object.measureTime (utils.ts:11:16)
    at immutableStateInvariantMiddleware.ts:193:22
    at actionCreatorInvariantMiddleware.ts:31:12
    at Main.tsx:139:13
On the login I can see the following error/warning in the console, but I can't replicate it each time (sent the screenshot) but I've only seen it now on `relay-controller` branch (also happened on logout click during the call and it prevented the logout, but unable to replicate). ``` Error: A state mutation was detected between dispatches, in the path 'relays.mostPopular.30'. This may cause incorrect behavior. (https://redux.js.org/style-guide/style-guide#do-not-mutate-state) at immutableStateInvariantMiddleware.ts:200:19 at Object.measureTime (utils.ts:11:16) at immutableStateInvariantMiddleware.ts:193:22 at actionCreatorInvariantMiddleware.ts:31:12 at Main.tsx:139:13 ```
src/controllers/RelayController.ts Outdated
@ -0,0 +80,4 @@
*
* @param {Filter} filter - The filter criteria to find the event.
* @param {string[]} [relays] - An optional array of relay URLs to search for the event.
* @returns {Promise<Event | null>} - Returns a promise that resolves to the found event or null if not found.
enes commented 2024-08-19 10:37:00 +00:00
Member
Copy Link

Small mismatch between comment and actual function return

Small mismatch between comment and actual function return
s commented 2024-08-20 08:56:06 +00:00
Author
Owner
Copy Link

fixed

fixed
s marked this conversation as resolved
s added 1 commit 2024-08-19 11:35:04 +00:00
chore: added a timeout of 30 seconds to subscription
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 32s
Details
2f1423a35a
s added 2 commits 2024-08-20 07:53:20 +00:00
chore: use spread operator in relay reducer for setting mostPopular relays
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 32s
Details
c274879adc
enes approved these changes 2024-08-20 08:50:42 +00:00
s added 1 commit 2024-08-20 08:55:48 +00:00
chore: update tsdoc for function defination in relay controller
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
a788309126
s commented 2024-08-20 08:56:58 +00:00
Author
Owner
Copy Link

On the login I can see the following error/warning in the console, but I can't replicate it each time (sent the screenshot) but I've only seen it now on relay-controller branch (also happened on logout click during the call and it prevented the logout, but unable to replicate).

Error: A state mutation was detected between dispatches, in the path 'relays.mostPopular.30'.  This may cause incorrect behavior. (https://redux.js.org/style-guide/style-guide#do-not-mutate-state)
    at immutableStateInvariantMiddleware.ts:200:19
    at Object.measureTime (utils.ts:11:16)
    at immutableStateInvariantMiddleware.ts:193:22
    at actionCreatorInvariantMiddleware.ts:31:12
    at Main.tsx:139:13

I have fixed it. Can you check again please?

> On the login I can see the following error/warning in the console, but I can't replicate it each time (sent the screenshot) but I've only seen it now on `relay-controller` branch (also happened on logout click during the call and it prevented the logout, but unable to replicate). > > ``` > Error: A state mutation was detected between dispatches, in the path 'relays.mostPopular.30'. This may cause incorrect behavior. (https://redux.js.org/style-guide/style-guide#do-not-mutate-state) > at immutableStateInvariantMiddleware.ts:200:19 > at Object.measureTime (utils.ts:11:16) > at immutableStateInvariantMiddleware.ts:193:22 > at actionCreatorInvariantMiddleware.ts:31:12 > at Main.tsx:139:13 > ``` I have fixed it. Can you check again please?
s closed this pull request 2024-08-20 08:56:58 +00:00
s reopened this pull request 2024-08-20 08:57:02 +00:00
enes added 1 commit 2024-08-20 11:52:35 +00:00
fix(relay-controller): sigit relay immutability and relay list
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 32s
Details
e0d6c03639
s added 1 commit 2024-08-20 12:12:12 +00:00
Merge branch 'staging' into relay-controller
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 32s
Details
0f8a40e9f0
s merged commit ba7d3fadbd into staging 2024-08-20 12:13:23 +00:00
s deleted branch relay-controller 2024-08-20 12:13:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
enes
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sigit/sigit.io#149
No description provided.
Delete Branch "relay-controller"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?