Sign Page - Sign order issue when creator signs second #158

New Issue

enes · 2024-08-20T15:19:14Z

enes commented

2024-08-20 15:19:14 +00:00

If a creator is a 2nd signer they skip over the awaiting sign page (sign when isReadyToSign returns early).

Possibly fix with updating the isReadyToSign or check if the current user is the next signer before returning PdfMarking?

If a creator is a 2nd signer they skip over the awaiting sign page (sign when `isReadyToSign` returns early). Possibly fix with updating the `isReadyToSign` or check if the current user is the next signer before returning `PdfMarking`?

enes added the

Kind/Bug

label 2024-08-20 15:19:14 +00:00

eugene self-assigned this 2024-08-26 09:45:34 +00:00

eugene referenced this issue

2024-08-27 13:21:10 +00:00

Signing Order #167

eugene commented

2024-08-27 13:23:01 +00:00

Following the PR with a fix, I have performed 3 tests.

Test 1.

Npub1: Creator and Signer 1
Npub2: Signer 2

Once the sigit is created, Npub1 instantly gets access to the signing page.
Npub2 doesn't receive a notification just yet.
Npub1 finishes signing.
The sigit now appears in the list of Npub2's sigits. Npub2 completes signing.
Npub1 needs to refresh their page, sign a decryption event (I think so!), and the Sigit shows in the list of Sigits as complete.

Test 2.

Npub1: Creator and Signer 2.
Npub2: Signer 1.

The sigit is created by Npub1. A screen showing all signers and their status appears. Signer 1 is not able to sign the Sigit out of order.
Npub2 received a notification and is able to complete the signing.
Npub1 refreshes the page and the Sigit now shows Npub2 as completed. Npub1 is able to proceed to complete the marks and signing.

Test .

Npub1: Creator and Signer 3.
Npub2: Signer 2.
Npub3: Signer 1.

Npub1 creates a Sigit but is unable to sign it.
The sigit appears in the list of Npub3's Sigits. Npub3 is able to sign it.
The sigit appears in the list of Npub2's Sigits. Npub 2 signs it.
Npub1 has to sign a decryption message, however the state of the Sigit is not fully updated. It shows that Npub3 has signed it, but that Npub2 is still pending.
15 minuts later, Npub1 is still unable to complete the signing.

Conclusions.

The immediate problem with the signing order has been fixed. However, it appears that there is an issue with notifications when there are more than 2 signers involved. I seem to remember that we have come across this issue before during out of the demos.

I'll create a ticket to investigate the notification problem.
I also wonder if there should be a button for each user to synchronise the current state of the sigit, in case there was some issue with the notifications.

Following the [PR with a fix](https://git.nostrdev.com/sigit/sigit.io/pulls/167), I have performed 3 tests. Test 1. Npub1: Creator and Signer 1 Npub2: Signer 2 Once the sigit is created, Npub1 instantly gets access to the signing page. Npub2 doesn't receive a notification just yet. Npub1 finishes signing. The sigit now appears in the list of Npub2's sigits. Npub2 completes signing. Npub1 needs to refresh their page, sign a decryption event (I think so!), and the Sigit shows in the list of Sigits as complete. Test 2. Npub1: Creator and Signer 2. Npub2: Signer 1. The sigit is created by Npub1. A screen showing all signers and their status appears. Signer 1 is not able to sign the Sigit out of order. Npub2 received a notification and is able to complete the signing. Npub1 refreshes the page and the Sigit now shows Npub2 as completed. Npub1 is able to proceed to complete the marks and signing. Test . Npub1: Creator and Signer 3. Npub2: Signer 2. Npub3: Signer 1. Npub1 creates a Sigit but is unable to sign it. The sigit appears in the list of Npub3's Sigits. Npub3 is able to sign it. The sigit appears in the list of Npub2's Sigits. Npub 2 signs it. Npub1 has to sign a decryption message, however the state of the Sigit is not fully updated. It shows that Npub3 has signed it, but that Npub2 is still pending. 15 minuts later, Npub1 is still unable to complete the signing. Conclusions. The immediate problem with the signing order has been fixed. However, it appears that there is an issue with notifications when there are more than 2 signers involved. I seem to remember that we have come across this issue before during out of the demos. I'll create a ticket to investigate the notification problem. I also wonder if there should be a button for each user to synchronise the current state of the sigit, in case there was some issue with the notifications.

enes referenced this issue

2024-09-10 12:03:27 +00:00

fix: processing gift wraps and notifications #193

enes referenced this issue from a commit

2024-09-12 08:27:00 +00:00

fix: processing gift wraps and notifications (#193)

Sign in to join this conversation.