sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

Counterparts section design update, touch dnd support, marks scrolling #182

Merged
enes merged 9 commits from 174-add-users-updates into staging 2024-09-06 10:22:56 +00:00
Conversation 2 Commits 9 Files Changed 8 +288 -271
enes commented 2024-09-05 07:34:41 +00:00
Member
Copy Link
  • Enabled touch support for dnd with detection (introduces react-dnd-multi-backend)
  • Updates the counterparties section with the newest design
  • Fix mark scrolling

Closes #174, #172

- Enabled touch support for dnd with detection (introduces `react-dnd-multi-backend`) - Updates the counterparties section with the newest design - Fix mark scrolling Closes #174, #172
enes added 6 commits 2024-09-05 07:34:41 +00:00
feat(create): touch support for dnd
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 35s
Details
3e075754e5
enes added 2 commits 2024-09-05 09:09:12 +00:00 
Closes #172
chore(git): merge pull request #183 from 172-sign-marks-scroll into 174-add-users-updates
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
479cca2180
enes changed title from Counterparts section design update and touch dnd support to Counterparts section design update, touch dnd support, marks scrolling 2024-09-05 09:10:32 +00:00
s requested changes 2024-09-05 10:05:16 +00:00
Dismissed
src/pages/create/index.tsx Outdated
@ -1015,0 +943,4 @@
onKeyDown={handleInputKeyDown}
error={!!error}
sx={{
fontSize: '16px',
s commented 2024-09-05 10:03:19 +00:00
Owner
Copy Link

This hardcoded inline style can be converted in to CSS class

This hardcoded inline style can be converted in to CSS class
👍 1
src/pages/create/index.tsx Outdated
@ -1015,0 +963,4 @@
}
variant="contained"
aria-label="Toggle User Role"
sx={{
s commented 2024-09-05 10:03:55 +00:00
Owner
Copy Link

Convert this inline style to css class

Convert this inline style to css class
👍 1
enes commented 2024-09-05 11:25:47 +00:00
Author
Member
Copy Link

Updated, moved all inline styles to the module scss with some higher specificity to override default styles.

Updated, moved all inline styles to the module scss with some higher specificity to override default styles.
enes added 1 commit 2024-09-05 11:24:53 +00:00
fix(review): remove inline styles
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 35s
Details
b8811d730a
enes requested review from s 2024-09-05 11:26:27 +00:00
s approved these changes 2024-09-06 10:22:10 +00:00
enes merged commit bf506705e6 into staging 2024-09-06 10:22:56 +00:00
enes deleted branch 174-add-users-updates 2024-09-06 10:22:57 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
s
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#182
No description provided.
Delete Branch "174-add-users-updates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?