subscribeForSigits and async gift wrap processing #194

New Issue

enes · 2024-09-10T12:39:53Z

enes commented

2024-09-10 12:39:53 +00:00

It was noticed we stop receiving new gift wraps (subscribes for events get closed), and only after refreshing we would get the new updates.

The issue was compounded by the race condition (related to the #193) and inability to check if we are already processing a sigit which caused us to show stale sigit data.

Additionally, processing can fail silently while at the same time we mark the gift wrap as processed.

To solve this, we need to:

update subscriptions so they stay open during the whole session,
make sure we add a mechanism to check if we are already processing a sigit (and to keep only the newest one)
make sure if we fail to process a gift wrap to actually remove it from processedGiftWraps list

It was noticed we stop receiving new gift wraps (subscribes for events get closed), and only after refreshing we would get the new updates. The issue was compounded by the race condition (related to the https://git.nostrdev.com/sigit/sigit.io/pulls/193) and inability to check if we are already processing a sigit which caused us to show stale sigit data. Additionally, processing can fail silently while at the same time we mark the gift wrap as processed. To solve this, we need to: - update subscriptions so they stay open during the whole session, - make sure we add a mechanism to check if we are already processing a sigit (and to keep only the newest one) - make sure if we fail to process a gift wrap to actually remove it from `processedGiftWraps` list

enes added the

Kind/Bug

Priority

High

labels 2024-09-10 12:39:53 +00:00

enes added the

Kind/Enhancement

label 2024-09-11 08:56:23 +00:00

enes referenced this issue from a commit

2024-09-11 11:13:23 +00:00

fix: add 2m interval to sigits update

enes referenced this issue