sigit/sigit.io
7
2
Fork 0
Code Issues 46 Pull Requests 4 Actions Packages Projects 1 Releases Wiki Activity

Searching counterparts glitchy when includes @ (nip05) #273

Merged
b merged 6 commits from issue-270 into staging 2024-12-10 15:37:00 +00:00
Conversation 1 Commits 6 Files Changed 3 +36 -18
m commented 2024-12-06 15:22:53 +00:00
Owner
Copy Link

Closes #270

Closes #270
m added 2 commits 2024-12-06 15:22:53 +00:00
fix: counterpart search NIP05 glitching
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 44s
Details
0fd0f26fc7
m changed title from issue-270 to https://git.nostrdev.com/sigit/sigit.io/pulls/273/files 2024-12-06 15:41:30 +00:00
m changed title from https://git.nostrdev.com/sigit/sigit.io/pulls/273/files to Searching counterparts glitchy when includes @ (nip05) 2024-12-06 15:41:40 +00:00
enes reviewed 2024-12-06 17:57:54 +00:00
enes left a comment
Member
Copy Link

I was unable to add root nip05 (eg nostrdev.com) directly like before. There was a hacky way to detect it before, there should a comment in user add function (maybe it will be useful for this case too).

I like how npub is recognized and the + is visible, but for nip05 (with @) it still shows search and on enter it blinks (quick loading screen I believe) and adds the user successfully, it would be nice to have + there too.

I was unable to add root nip05 (eg `nostrdev.com`) directly like before. There was a hacky way to detect it before, there should a comment in user add function (maybe it will be useful for this case too). I like how npub is recognized and the + is visible, but for nip05 (with @) it still shows search and on enter it blinks (quick loading screen I believe) and adds the user successfully, it would be nice to have + there too.
src/components/AppBar/AppBar.tsx
@ -126,3 +126,3 @@
alt="Logo"
onClick={() => {
if (window.location.pathname === '/') {
if (['', '#/'].includes(window.location.hash)) {
enes commented 2024-12-06 17:46:04 +00:00
Member
Copy Link

We should apply this hash check instead of pathname to the Footer.tsx as well.

We should apply this hash check instead of pathname to the `Footer.tsx` as well.
m marked this conversation as resolved
m added 1 commit 2024-12-06 19:58:37 +00:00
fix: search counterparts nip05 does not need to include '@'
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 50s
Details
7b29d7055e
m added 1 commit 2024-12-06 20:00:59 +00:00
fix: footer 'Home' button scroll to top when on home page, fixed logic
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 46s
Details
afbe05b4c8
m commented 2024-12-06 20:02:53 +00:00
Author
Owner
Copy Link

@enes

I was unable to add root nip05 (eg nostrdev.com) directly like before. There was a hacky way to detect it before, there should a comment in user add function (maybe it will be useful for this case too).

I like how npub is recognized and the + is visible, but for nip05 (with @) it still shows search and on enter it blinks (quick loading screen I believe) and adds the user successfully, it would be nice to have + there too.

It's still kind of a search against well-known, it's not certain that NIP05 exists, so I would prefer to keep the search icon

@enes > I was unable to add root nip05 (eg `nostrdev.com`) directly like before. There was a hacky way to detect it before, there should a comment in user add function (maybe it will be useful for this case too). > > I like how npub is recognized and the + is visible, but for nip05 (with @) it still shows search and on enter it blinks (quick loading screen I believe) and adds the user successfully, it would be nice to have + there too. It's still kind of a search against well-known, it's not certain that NIP05 exists, so I would prefer to keep the search icon
👍 1
enes reviewed 2024-12-09 10:53:43 +00:00
enes left a comment
Member
Copy Link

Depending if I click "+" or press "Enter" after pasting npub directly I get different result, enter adds successfully but clicking button shows Invalid input! Make sure to provide correct npub or nip05. message.

Depending if I click "+" or press "Enter" after pasting `npub` directly I get different result, enter adds successfully but clicking button shows `Invalid input! Make sure to provide correct npub or nip05.` message.
m added 1 commit 2024-12-10 14:29:34 +00:00
fix: bug, when valid npub, clicking + was saying npub was invalid
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 44s
Details
99fa3add56
m requested review from enes 2024-12-10 14:35:00 +00:00
enes approved these changes 2024-12-10 15:00:20 +00:00
b added 1 commit 2024-12-10 15:36:46 +00:00
Merge branch 'staging' into issue-270
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 41s
Details
1c0984cb3b
b merged commit c3e4f6055c into staging 2024-12-10 15:37:00 +00:00
b deleted branch issue-270 2024-12-10 15:37:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
enes
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sigit/sigit.io#273
No description provided.
Delete Branch "issue-270"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?