sigit/sigit.io
7
2
Fork 0
Code Issues 41 Pull Requests 3 Actions Packages Projects 1 Releases Wiki Activity

#288 Fixes Sign and Complete Spinner Issue #301

Merged
eugene merged 1 commits from issue-288-sign-complete-spinner-fix into staging 2025-01-08 12:25:18 +00:00
Conversation 0 Commits 1 Files Changed 1 +31 -23
eugene commented 2025-01-08 10:32:41 +00:00
Owner
Copy Link

This PR fixes #288.

The loading state is interruped before the app navigates to the /validate screen because a redundant useEffect re-render of the page is triggered by a Sigit update.

Solution:

  • MetaInNavState is memoised to avoid redundant state updates
  • A new UseEffect hook is added to triggered the initial Sigit computation on mount.
This PR fixes #288. The loading state is interruped before the app navigates to the /validate screen because a redundant useEffect re-render of the page is triggered by a Sigit update. Solution: - MetaInNavState is memoised to avoid redundant state updates - A new UseEffect hook is added to triggered the initial Sigit computation on mount.
eugene added 1 commit 2025-01-08 10:32:41 +00:00
fix: disables redundant metaInNavState updates
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 38s
Details
746338465d
eugene requested review from m 2025-01-08 10:44:11 +00:00
eugene requested review from enes 2025-01-08 10:44:12 +00:00
enes approved these changes 2025-01-08 11:00:10 +00:00
eugene merged commit fdaae33aa1 into staging 2025-01-08 12:25:18 +00:00
eugene deleted branch issue-288-sign-complete-spinner-fix 2025-01-08 12:25:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
m
enes
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sigit/sigit.io#301
No description provided.
Delete Branch "issue-288-sign-complete-spinner-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?