sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 5 Actions Packages Projects 1 Releases 5 Wiki Activity

npubs should be validated #308

New Issue
Open
opened 2025-01-30 11:39:20 +00:00 by b · 1 comment
b commented 2025-01-30 11:39:20 +00:00
Owner
Copy Link

If the counterparty string starts with npub1 then we should validate the npub

We had a situation today where a user was unable to add a counterparty, and did not realise his npub was invalid. Nosta Me manages this ok:

https://nosta.me/npub1qnkhmdy37hltzfslu6m3vfylymhwyumgjmasnrc0qqq2kfnrqrxlsxr6ny8

ALSO - we had an issue with an npub not working because it had a leading space

both leading and trailing blanks should be automatically removed (but keep the ability to type them, eg "Tom Jones")

If the counterparty string starts with `npub1` then we should validate the npub We had a situation today where a user was unable to add a counterparty, and did not realise his npub was invalid. Nosta Me manages this ok: https://nosta.me/npub1qnkhmdy37hltzfslu6m3vfylymhwyumgjmasnrc0qqq2kfnrqrxlsxr6ny8 ALSO - we had an issue with an npub not working because it had a leading space both leading and trailing blanks should be automatically removed (but keep the ability to type them, eg "Tom Jones")
enes self-assigned this 2025-02-07 17:09:04 +00:00
enes added this to the MVP project 2025-02-07 17:09:12 +00:00
enes added the
Kind/Bug
 label 2025-02-07 17:09:19 +00:00
enes moved this to In Progress in MVP on 2025-02-07 17:09:30 +00:00
enes commented 2025-02-07 18:12:47 +00:00
Member
Copy Link

@b We have been validating the input and the npub, but if it was not valid npub1 we did normal search instead as a fallback
We could skip this fallback and show the error message instead? What are the chances someones user name starts with npub1?

@b We have been validating the input and the npub, but if it was not valid `npub1` we did normal search instead as a fallback We could skip this fallback and show the error message instead? What are the chances someones user name starts with `npub1`?
enes moved this to Pending in MVP on 2025-02-18 16:46:54 +00:00
enes moved this to In Progress in MVP on 2025-02-18 16:47:12 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Kind/Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project MVP
Assignees
Clear assignees
b endo enes eugene freakoverse goat humblegoat kodo m rnd s y
No Assignees enes
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#308
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?