sigit/sigit.io
7
2
Fork 0
Code Issues25 Pull Requests1 Actions Packages Projects1 Releases6 Wiki Activity

feat: enable pwa #324

Merged
enes merged 4 commits from tbk/pwa into staging 2025-04-03 11:40:05 +00:00
Conversation 7 Commits 4 Files Changed 12 +84
tbk commented 2025-04-01 09:17:53 +00:00
Collaborator

This PR addresses 2 of 3 tasks from .

It is the simplest approach installing SIGit as PWA.
Let me know if this is applicable and whether the third task can be done in a follow-up PR. 🙏

What it does:

  • It should be possible to download SIGit as a PWA on a device homescreen.
  • This app should self-update

What it does not, but can be done in a follow-up PR:

  • The user should be prompted to download the PWA

image.png
image.png
image.png
image.png

This PR addresses 2 of 3 tasks from #93. It is the simplest approach installing SIGit as PWA. Let me know if this is applicable and whether the third task can be done in a follow-up PR. 🙏 What it does: - [x] It should be possible to download SIGit as a PWA on a device homescreen. - [x] This app should self-update What it does not, but can be done in a follow-up PR: - The user should be prompted to download the PWA ![image.png](/attachments/2d49acb8-585f-4a68-bd55-6dc6ec700f10) ![image.png](/attachments/0d41f56e-c590-4cdb-8e14-c869468519a7) ![image.png](/attachments/686541cd-ee3c-42db-8d57-ce5626654b96) ![image.png](/attachments/f3fcfd05-6568-46ca-8317-0075fb8bbb6c)
image.png
17 KiB
image.png
24 KiB
image.png
9.1 KiB
image.png
8.9 KiB
tbk added 1 commit 2025-04-01 09:17:53 +00:00
tbk added the
Kind/Feature
 label 2025-04-01 09:18:09 +00:00
enes commented 2025-04-01 10:16:49 +00:00
Member

I believe the new recommendation is to use .webmanifest extension eg. app.webmanifest instead of .json.

Prompt for the follow-up PR is fine.

Edit: Couple of warnings with icon and screenshots, but this shouldn't affect installation critera, would be a nice-to-have the form factors too, can be included in the follow-up.

I believe the new recommendation is to use `.webmanifest` extension eg. `app.webmanifest` instead of `.json`. Prompt for the follow-up PR is fine. Edit: Couple of warnings with icon and screenshots, but this shouldn't affect installation critera, would be a nice-to-have the form factors too, can be included in the follow-up.
Screenshot 2025-04-01 at 11.55.55.jpg
94 KiB
Screenshot 2025-04-01 at 11.55.55.jpg
👍 1
enes requested changes 2025-04-01 10:19:52 +00:00
Dismissed
enes left a comment
Member

Use .webmanifest extension.

Use `.webmanifest` extension.
👍 1
tbk commented 2025-04-01 11:49:51 +00:00
Author
Collaborator

Hey @enes! Thanks 🙏

Will rename! I can also add the logo in different formats.

Hey @enes! Thanks 🙏 Will rename! I can also add the logo in different formats.
tbk added 2 commits 2025-04-02 08:54:15 +00:00
tbk commented 2025-04-02 08:56:40 +00:00
Author
Collaborator

Use .webmanifest extension.

Done.
Also added description, display_override and orientation.
Icons sizes 64x64, 72x72, 96x96, 128x128, 144x144, 192x192, 256x256, 384x384 and 512x512.

> Use `.webmanifest` extension. Done. Also added `description`, `display_override` and `orientation`. Icons sizes 64x64, 72x72, 96x96, 128x128, 144x144, 192x192, 256x256, 384x384 and 512x512.
👍 1
b commented 2025-04-02 10:40:47 +00:00
Owner

unrelated issue with a dependency - perhaps we can try npm audit fix?

image.png

unrelated issue with a dependency - perhaps we can try `npm audit fix`? ![image.png](/attachments/23bc6bba-7744-482a-ba6e-082b68327f45)
image.png
111 KiB
tbk commented 2025-04-02 17:40:16 +00:00
Author
Collaborator

unrelated issue with a dependency - perhaps we can try npm audit fix?

Fixed in

> unrelated issue with a dependency - perhaps we can try `npm audit fix`? Fixed in #325
tbk self-assigned this 2025-04-02 17:45:25 +00:00
b added 1 commit 2025-04-03 11:16:33 +00:00
enes approved these changes 2025-04-03 11:30:14 +00:00
enes merged commit 13044d6b39 into staging 2025-04-03 11:40:05 +00:00
enes deleted branch tbk/pwa 2025-04-03 11:40:05 +00:00
enes referenced this issue from a commit 2025-04-03 11:40:06 +00:00
feat: enable pwa (#324)
Sign in to join this conversation.
No Reviewers
enes
No Label
Kind/Feature
No Milestone
No project
No Assignees tbk
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#324
No description provided.
Delete Branch "tbk/pwa"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?