sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

Login with NSEC and HEX private key formats. Proper errors. #66

Merged
b merged 5 commits from issue-45 into main 2024-05-24 08:35:33 +00:00
Conversation 2 Commits 5 Files Changed 2 +45 -9
m commented 2024-05-22 10:22:23 +00:00
Owner
Copy Link
No description provided.
m added 2 commits 2024-05-22 10:22:24 +00:00
m added 1 commit 2024-05-22 10:31:05 +00:00
y reviewed 2024-05-24 02:32:31 +00:00
src/pages/login/index.tsx
@ -310,1 +326,3 @@
toast.error('Invalid Input!')
// Check if maybe hex nsec
try {
// const privateKey = nip19.decode(inputValue).data as Uint8Array
y commented 2024-05-24 02:29:33 +00:00
Owner
Copy Link

Please remove not used code

Please remove not used code
m marked this conversation as resolved
src/pages/login/index.tsx Outdated
@ -330,3 +359,3 @@
<TextField
onKeyDown={handleInputKeyDown}
label="nip05 login / nip46 bunker string / nsec"
label="nip05 login / nip46 bunker string"
y commented 2024-05-24 02:31:55 +00:00
Owner
Copy Link

Shouldn't nsec be one of the options?

Shouldn't `nsec` be one of the options?
m commented 2024-05-24 06:51:41 +00:00
Author
Owner
Copy Link

@b said that we should not display it so we do not encourage users to use it. But it is visible in the error message if user types in something wrong.

@b said that we should not display it so we do not encourage users to use it. But it is visible in the error message if user types in something wrong.
👍 1
y marked this conversation as resolved
m added 2 commits 2024-05-24 06:52:47 +00:00
y approved these changes 2024-05-24 06:55:44 +00:00
b merged commit 9caba52f7d into main 2024-05-24 08:35:33 +00:00
b deleted branch issue-45 2024-05-24 08:35:33 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
y
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#66
No description provided.
Delete Branch "issue-45"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?