sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

Remove Kind 1 #76

New Issue
Closed
opened 2024-05-24 15:53:00 +00:00 by b · 0 comments
b commented 2024-05-24 15:53:00 +00:00
Owner
Copy Link

Kind 1 events are typically used to broadcast to relays. However SIGit uses them for checking signatures, and creating signEvents (does not broadcast).

Users are right to be suspicious when granting kind 1 signing rights to applications. Therefore SIGit should use a different kind.

Recommendation - use kind 27235 as defined in NIP-98

We can use the same for the signEvents, to avoid asking the user to approve two permission types.

Kind 1 events are typically used to broadcast to relays. However SIGit uses them for checking signatures, and creating signEvents (does not broadcast). Users are right to be suspicious when granting kind 1 signing rights to applications. Therefore SIGit should use a different kind. Recommendation - use kind 27235 as defined in [NIP-98](https://github.com/nostr-protocol/nips/blob/master/98.md) We can use the same for the signEvents, to avoid asking the user to approve two permission types.
b added the
Kind/Testing
 label 2024-05-24 15:57:24 +00:00
b added this to the MVP project 2024-05-24 15:57:26 +00:00
s self-assigned this 2024-05-27 09:41:40 +00:00
b closed this issue 2024-05-27 12:04:36 +00:00
enes moved this to Done in MVP on 2025-01-20 19:18:15 +00:00
enes moved this to Done in MVP on 2025-01-20 19:19:31 +00:00
enes moved this to Done in MVP on 2025-01-20 19:34:21 +00:00
enes moved this to Done in MVP on 2025-01-22 16:11:33 +00:00
enes moved this to Done in MVP on 2025-01-22 16:11:36 +00:00
enes moved this to Done in MVP on 2025-01-22 16:11:38 +00:00
enes moved this to Done in MVP on 2025-01-22 16:11:40 +00:00
enes moved this to Done in MVP on 2025-01-22 16:11:43 +00:00
s moved this to Done in MVP on 2025-01-24 09:16:21 +00:00
s moved this to Done in MVP on 2025-01-24 09:16:26 +00:00
enes moved this to Done in MVP on 2025-01-24 09:37:11 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Kind/Testing
Milestone
No items
No Milestone
Projects
Clear projects
No project MVP
Assignees
Clear assignees
No Assignees s
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#76
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?