sigit/sigit.io
6
2
Fork 0
Code Issues 41 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

Add Sigit ID as a path param #195

Open
m wants to merge 10 commits from issue-171 into staging
pull from: issue-171
merge into: sigit:staging
Conversation 2 Commits 10 Files Changed 4 +3 -5
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7c027825cd - Show all commits

8
src/pages/sign/index.tsx
View File

@ -74,11 +74,9 @@ export const SignPage = () => {
* arrayBuffer will be received in navigation from create page in offline mode
* meta will be received in navigation from create & home page in online mode
m marked this conversation as resolved Outdated
enes commented 2024-09-10 15:49:34 +00:00
Outdated
Review
Copy Link

We should just replace the value of metaInNavState without having states.
We can just move it out of the destructuring and modify it if needed? Something like?

  const { arrayBuffer: decryptedArrayBuffer, uploadedZip } = location.state

  let metaInNavState = location.state.meta
  if (usersAppData) {
    const sigitId = params.id

    if (sigitId) {
      metaInNavState = usersAppData.sigits[sigitId]
    }
  }
We should just replace the value of `metaInNavState` without having states. We can just move it out of the destructuring and modify it if needed? Something like? ``` const { arrayBuffer: decryptedArrayBuffer, uploadedZip } = location.state let metaInNavState = location.state.meta if (usersAppData) { const sigitId = params.id if (sigitId) { metaInNavState = usersAppData.sigits[sigitId] } } ```
*/
const {
meta: metaInNavState,
arrayBuffer: decryptedArrayBuffer,
uploadedZip
} = location.state || {
let metaInNavState = location.state.meta
const { arrayBuffer: decryptedArrayBuffer, uploadedZip } = location.state || {
meta: undefined,
arrayBuffer: undefined,
uploadedZip: undefined