sigit/sigit.io
6
2
Fork 0
Code Issues 41 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

Add Sigit ID as a path param #195

Open
m wants to merge 10 commits from issue-171 into staging
pull from: issue-171
merge into: sigit:staging
Conversation 2 Commits 10 Files Changed 4 +10 -6
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 86a16c13ce - Show all commits

16
src/pages/sign/index.tsx
View File

@ -71,18 +71,22 @@ export const SignPage = () => {
* Received from `location.state` * Received from `location.state`
* *
* uploadedZip will be received from home page when a user uploads a sigit zip wrapper that contains keys.json * uploadedZip will be received from home page when a user uploads a sigit zip wrapper that contains keys.json
* arrayBuffer will be received in navigation from create page in offline mode * arrayBuffer (decryptedArrayBuffer) will be received in navigation from create page in offline mode
* meta will be received in navigation from create & home page in online mode * meta (metaInNavState) will be received in navigation from create & home page in online mode
m marked this conversation as resolved Outdated
enes commented 2024-09-10 15:49:34 +00:00
Outdated
Review
Copy Link

We should just replace the value of metaInNavState without having states.
We can just move it out of the destructuring and modify it if needed? Something like?

  const { arrayBuffer: decryptedArrayBuffer, uploadedZip } = location.state

  let metaInNavState = location.state.meta
  if (usersAppData) {
    const sigitId = params.id

    if (sigitId) {
      metaInNavState = usersAppData.sigits[sigitId]
    }
  }
We should just replace the value of `metaInNavState` without having states. We can just move it out of the destructuring and modify it if needed? Something like? ``` const { arrayBuffer: decryptedArrayBuffer, uploadedZip } = location.state let metaInNavState = location.state.meta if (usersAppData) { const sigitId = params.id if (sigitId) { metaInNavState = usersAppData.sigits[sigitId] } } ```
*/ */
let metaInNavState = location.state.meta let metaInNavState = location?.state?.meta || undefined
const { arrayBuffer: decryptedArrayBuffer, uploadedZip } = location.state || { const { arrayBuffer: decryptedArrayBuffer, uploadedZip } = location.state || {
meta: undefined, decryptedArrayBuffer: undefined,
arrayBuffer: undefined,
uploadedZip: undefined uploadedZip: undefined
} }
/**
* If userAppData (redux) is available, and we have route param (sigit id)
m marked this conversation as resolved Outdated
b commented 2024-09-11 11:18:37 +00:00
Outdated
Review
Copy Link

sigit id - what is this? should be defined

sigit id - what is this? should be defined
* we will fetch a sigit based on the provided route ID and set it
* to the metaInNavState
*/
if (usersAppData) { if (usersAppData) {
// Sigit id is a createEventId
const sigitId = params.id const sigitId = params.id
if (sigitId) { if (sigitId) {