degmods/degmods.com
6
1
Fork 0
Code Issues 24 Pull Requests Actions Packages Projects 3 Releases Wiki Activity

Fixes for #120, #117, #84, #104 #123

Merged
enes merged 8 commits from fixes-120-117-84-104 into staging 2024-11-14 16:02:05 +00:00
Conversation 0 Commits 8 Files Changed 9 +124 -76
enes commented 2024-11-14 14:01:41 +00:00
Collaborator
Copy Link

This PR fixes the following issues:
#120 - accept npub as valid nprofile param, encode and redirect
#117 - fix profile links in comments
#84 - add spinners and timeouts to make sure comments and reactions show loading and states correctly
#104 - add initial spinner for 15 seconds (initial comment loading fix)

Edit:
#104 - reduce initial spinner, hold the newly discovered (fetched) comments to avoid abrupt layout shifts, allow user to click a button to load

This PR fixes the following issues: #120 - accept `npub` as valid `nprofile` param, encode and redirect #117 - fix profile links in comments #84 - add spinners and timeouts to make sure comments and reactions show loading and states correctly #104 - add initial spinner for 15 seconds (initial comment loading fix) Edit: #104 - reduce initial spinner, hold the newly discovered (fetched) comments to avoid abrupt layout shifts, allow user to click a button to load
enes added 7 commits 2024-11-14 14:01:41 +00:00 
Closes #120
Closes #117
enes added 1 commit 2024-11-14 15:51:16 +00:00
enes merged commit df0c64e2c9 into staging 2024-11-14 16:02:05 +00:00
enes deleted branch fixes-120-117-84-104 2024-11-14 16:02:05 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: degmods/degmods.com#123
No description provided.
Delete Branch "fixes-120-117-84-104"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?