degmods/degmods.com
5
1
Fork 0
Code Issues45 Pull Requests Actions Packages Projects4 Releases Wiki Activity

Fixes for , , , #123

Merged
enes merged 8 commits from fixes-120-117-84-104 into staging 2024-11-14 16:02:05 +00:00
Conversation 0 Commits 8 Files Changed 9 +124 -76
enes commented 2024-11-14 14:01:41 +00:00
Collaborator

This PR fixes the following issues:
- accept npub as valid nprofile param, encode and redirect
- fix profile links in comments
- add spinners and timeouts to make sure comments and reactions show loading and states correctly
- add initial spinner for 15 seconds (initial comment loading fix)

Edit:
- reduce initial spinner, hold the newly discovered (fetched) comments to avoid abrupt layout shifts, allow user to click a button to load

This PR fixes the following issues: #120 - accept `npub` as valid `nprofile` param, encode and redirect #117 - fix profile links in comments #84 - add spinners and timeouts to make sure comments and reactions show loading and states correctly #104 - add initial spinner for 15 seconds (initial comment loading fix) Edit: #104 - reduce initial spinner, hold the newly discovered (fetched) comments to avoid abrupt layout shifts, allow user to click a button to load
enes added 7 commits 2024-11-14 14:01:41 +00:00 
Closes 
Closes
enes added 1 commit 2024-11-14 15:51:16 +00:00
enes merged commit df0c64e2c9 into staging 2024-11-14 16:02:05 +00:00
enes deleted branch fixes-120-117-84-104 2024-11-14 16:02:05 +00:00
Sign in to join this conversation.
No Reviewers
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: degmods/degmods.com#123
No description provided.
Delete Branch "fixes-120-117-84-104"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?