sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 3 Actions Packages Projects 1 Releases Wiki Activity

Fix infinite loading - sign page, clicking sign #137

New Issue
Closed
opened 2024-08-12 14:38:28 +00:00 by enes · 1 comment
enes commented 2024-08-12 14:38:28 +00:00
Member
Copy Link

Sign page gets stuck on loading screen when we click sign button

Caused with sigit with when:

  • we add non-pdf file (no marks)
  • we add a pdf file without any marks added
  • we add a mark to a pdf file and we don't assign anyone to it (related to #145)
Sign page gets stuck on loading screen when we click `sign` button Caused with sigit with when: - [x] we add non-pdf file (no marks) - [x] we add a pdf file without any marks added - [x] we add a mark to a pdf file and we don't assign anyone to it (related to https://git.nostrdev.com/sigit/sigit.io/issues/145)
enes added the
Kind/Bug
 label 2024-08-12 14:38:28 +00:00
enes added the
Priority
High
 label 2024-08-15 12:27:21 +00:00
enes self-assigned this 2024-08-26 12:31:23 +00:00
enes commented 2024-08-28 08:14:17 +00:00
Author
Member
Copy Link

Infinite loading on the sign is fixed:

Caused with sigit with when:

  • we add non-pdf file (no marks)
  • we add a pdf file without any marks added
  • we add a mark to a pdf file and we don't assign anyone to it (related to #145)
  • signing of non-pdf files is possible
  • signing a pdf without any marks is possible
  • adding a mark without counterpart now throws a toast error
Infinite loading on the sign is fixed: > Caused with sigit with when: > - [x] we add non-pdf file (no marks) > - [x] we add a pdf file without any marks added > - [x] we add a mark to a pdf file and we don't assign anyone to it (related to https://git.nostrdev.com/sigit/sigit.io/issues/145) - signing of non-pdf files is possible - signing a pdf without any marks is possible - adding a mark without counterpart now throws a toast error
enes closed this issue 2024-08-29 11:02:20 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Kind/Bug
Priority
High
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees enes
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#137
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?