fix: load screen on sign, block on missing counterpart #170

enes · 2024-08-28T11:21:59Z

enes commented

2024-08-28 11:21:59 +00:00

Fix:

allow signing with no marks (enables signing images and other files)
adding a mark without counterpart now throws a toast error

Additional:

fix content column size (add wrapping)

Closes #137

Fix: - allow signing with no marks (enables signing images and other files) - adding a mark without counterpart now throws a toast error Additional: - fix content column size (add wrapping) Closes #137

enes added 15 commits 2024-08-28 11:21:59 +00:00

fix(pdf): font style consistency 31f36750cd

fix(pdf): scaling and font styles consistency ac3186a02e

Closes #146

fix(pdf): add border to style ecc1707212

fix(pdf): dynamic mark scaling ea09daa669

Caveat: scaling is not fluid, refresh is required

refactor(pdf): remove unused code 8c5be3713d

fix(pdf): scaling on resize, add avatars to counterpart select 4712031615

fix(drawfield): match label and select 923a47b4d0

fix(pdf): add proper default width value a442e71087

fix(pdf): reuse content width function 59c3fc69a2

chore: comment typo e854dca2e1

fix(create): throw on mark with no counterpart 2ea9afb3a3

refactor(error): refactor SigitMetaParseError 7a685c6cfe

refactor(error): refactor MetaParseError 2 4a265d7ce7

fix(column-layout): wrap content column to prevent expanding d3924a063d

fix(sign): allow signing without marks, hide loading and show toast for prevSig error 35b1378aa7

enes force-pushed 137-sign-loading-error from 35b1378aa7 to 20d1170f7d

2024-08-28 11:26:52 +00:00

Compare

enes requested review from eugene 2024-08-28 12:14:07 +00:00

eugene reviewed 2024-08-29 09:43:22 +00:00

src/pages/create/index.tsx

						
				@ -727,3 +730,1 @@

				    setLoadingSpinnerDesc('Generating file hashes')

				    const fileHashes = await generateFileHashes()

				    if (!fileHashes) {

				      setIsLoading(true)

eugene commented

2024-08-29 09:43:22 +00:00

I wonder if this flow should be refactored, given our recent conversation about error handling. I also thing that there are more efficient ways to handle loading state changes.

Having said that, perhaps it is best left to a separate PR. Worth adding as an issue?

I wonder if this flow should be refactored, given our recent conversation about error handling. I also thing that there are more efficient ways to handle loading state changes. Having said that, perhaps it is best left to a separate PR. Worth adding as an issue?

👍 1

enes commented

2024-08-29 10:25:32 +00:00

I think we can for now just leave finally, to execute setIsLoading(false) once, we don't need it in each return

I think we can for now just leave `finally`, to execute `setIsLoading(false)` once, we don't need it in each return

eugene reviewed 2024-08-29 09:44:14 +00:00

src/pages/create/index.tsx

						
				@ -730,0 +804,4 @@

				        setLoadingSpinnerDesc('Sending notifications to counterparties')

				        const promises = sendNotifications(meta)

				        await Promise.all(promises)

eugene commented

2024-08-29 09:44:14 +00:00

A promise doesn't need to be awaited if chaining is used.

enes commented

2024-08-29 10:17:25 +00:00

We are blocking so we don't navigate away before .all is done.
Another question is if we need to block at all since even if it's rejected, we proceed to another page anyway?

We are blocking so we don't navigate away before `.all` is done. Another question is if we need to block at all since even if it's rejected, we proceed to another page anyway?

eugene reviewed 2024-08-29 09:44:40 +00:00

src/pages/sign/index.tsx

						
				@ -543,3 +543,3 @@

				    const prevSig = getPrevSignersSig(hexToNpub(usersPubkey!))

				    if (!prevSig) return

				    if (!prevSig) {