sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

fix(marks): add default signer #207

Merged
enes merged 3 commits from 145-default-signer into 201-toolbox-update 2024-09-19 11:24:17 +00:00
Conversation 2 Commits 3 Files Changed 1 +61 -57
enes commented 2024-09-17 15:32:07 +00:00
Member
Copy Link

Closes #145

Closes #145
enes added 2 commits 2024-09-17 15:32:07 +00:00
refactor(toolbox): reduce number of mark types
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
f8a4480994 
Closes #201
fix(marks): add default signer
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
dfdcb8419d
enes changed title from fix(marks): add default signer to WIP: fix(marks): add default signer 2024-09-18 08:48:12 +00:00
eugene reviewed 2024-09-18 09:48:59 +00:00
src/utils/mark.ts Outdated
@ -201,4 +177,2 @@
label: 'Number',
active: false
},
{
eugene commented 2024-09-18 09:48:59 +00:00
Owner
Copy Link

Isn't what the first PR already doing? And similar comment to the first PR - can we rely on the active flag rather than commenting out?

Isn't what the first PR already doing? And similar comment to the first PR - can we rely on the `active` flag rather than commenting out?
enes commented 2024-09-18 09:54:28 +00:00
Author
Member
Copy Link

I mentioned this one is branched off the 201 so it includes the other PR commit.

I mentioned this one is branched off the 201 so it includes the other PR commit.
eugene commented 2024-09-19 10:30:10 +00:00
Owner
Copy Link

Do you still need the other PR?

Do you still need the other PR?
enes commented 2024-09-19 11:19:52 +00:00
Author
Member
Copy Link

I'll combine this with the 201 so there's no confusion

I'll combine this with the 201 so there's no confusion
eugene reviewed 2024-09-18 09:49:34 +00:00
src/components/DrawPDFFields/index.tsx
@ -536,3 +534,3 @@
if (metadata) {
displayValue = truncate(
metadata.name || metadata.display_name || metadata.username || value,
metadata.display_name || metadata.name || npub,
eugene commented 2024-09-18 09:49:34 +00:00
Owner
Copy Link

Should this be turned into a utilitiy function, something like getDisplayName that can then be re-used wherever needed?

Should this be turned into a utilitiy function, something like `getDisplayName` that can then be re-used wherever needed?
enes commented 2024-09-18 09:58:21 +00:00
Author
Member
Copy Link

Yes, there are a few places where this shows up, there are also variation with truncate and shorten, I've opened up a new issue to check since I expect more places where it need fixing #205

Yes, there are a few places where this shows up, there are also variation with truncate and shorten, I've opened up a new issue to check since I expect more places where it need fixing https://git.nostrdev.com/sigit/sigit.io/issues/205
eugene commented 2024-09-19 10:31:00 +00:00
Owner
Copy Link

I think it's a fairly minor refactor and can be done as part of the same PR

I think it's a fairly minor refactor and can be done as part of the same PR
enes commented 2024-09-19 10:43:50 +00:00
Author
Member
Copy Link

Okay, on it!

Okay, on it!
enes added 1 commit 2024-09-19 09:46:48 +00:00
fix: last signer as default next
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
39934f59c3
enes changed title from WIP: fix(marks): add default signer to fix(marks): add default signer 2024-09-19 09:47:21 +00:00
enes changed target branch from staging to 201-toolbox-update 2024-09-19 11:19:17 +00:00
enes added 1 commit 2024-09-19 11:20:07 +00:00
enes merged commit a1bf88d243 into 201-toolbox-update 2024-09-19 11:24:17 +00:00
enes deleted branch 145-default-signer 2024-09-19 11:24:17 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#207
No description provided.
Delete Branch "145-default-signer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?