sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 5 Actions Packages Projects 1 Releases 5 Wiki Activity

Unique sender for sigit when sending private DMs #319

New Issue
Open
opened 2025-02-07 16:37:13 +00:00 by enes · 1 comment
enes commented 2025-02-07 16:37:13 +00:00
Member
Copy Link

Bonus feature, enhancement for the private DMs feature

The current implementation sends a private DM with a randomly generated npub/nsec combination, even if DM updates are related to a same sigit.

It would be nice if all related updates come under the same "sender" so that all messages arrive in the same conversation.
This would mean that there is a unique "sender" per sigit.

Reference:

Bonus feature, enhancement for the private DMs feature The current implementation sends a private DM with a randomly generated `npub/nsec` combination, even if DM updates are related to a same sigit. It would be nice if all related updates come under the same "sender" so that all messages arrive in the same conversation. This would mean that there is a unique "sender" per sigit. Reference: - Issue: https://git.nostrdev.com/sigit/sigit.io/issues/92 - Feature PR: https://git.nostrdev.com/sigit/sigit.io/pulls/230
enes added the
Kind/Enhancement
Status
Need More Info
Priority
Low
 labels 2025-02-07 16:37:13 +00:00
b commented 2025-02-09 11:31:07 +00:00
Owner
Copy Link

For NIP-17 this isn't an issue right? As the seal (kind 13) is signed with the sender public key.

Probably we should just deprecate the kind-4 DM approach entirely.

For [NIP-17](https://github.com/nostr-protocol/nips/blob/master/17.md) this isn't an issue right? As the seal (kind 13) is signed with the sender public key. Probably we should just deprecate the kind-4 DM approach entirely.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Kind/Enhancement
Priority
Low
Status
Need More Info
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
b endo enes eugene freakoverse goat humblegoat kodo m rnd s y
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#319
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?