Final DM (SIGit complete) not being sent #92

New Issue

b · 2024-05-29T09:54:19Z

b commented

2024-05-29 09:54:19 +00:00

When the final signer has signed, the notification email (SIGit complete + link) is not being sent

b changed title from ~~Final email (SIGit complete) not being sent~~ to Final DM (SIGit complete) not being sent

2024-05-29 15:06:26 +00:00

enes referenced this issue

2024-09-06 16:11:58 +00:00

Sigit Routing - Add Sigit ID as a Path Param #171

enes self-assigned this 2024-10-09 12:29:06 +00:00

enes commented

2024-10-09 12:34:32 +00:00

@b

Do we want to have a link to the /sign or a /verify in the DM?
Should we send the DM as the user (last signer) or generate random private key for sending?

@b 1. Do we want to have a link to the /sign or a /verify in the DM? 2. Should we send the DM as the user (last signer) or generate random private key for sending?

b commented

2024-10-09 13:07:04 +00:00

We can't send a kind 4 DM as the signer, as that would leak a relationship between the signers

We should either send gift-wrapped DMs or a DM from a random NPUB as you suggest

Probably kind-17 makes the most sense as otherwise the SIGit DMs could be an attack vector (trick people into visiting a dangerous url)

About the link - it should be /sign or /verify depending on whether the target NPUB is the next signer or not

We can't send a kind 4 DM as the signer, as that would leak a relationship between the signers We should either send gift-wrapped DMs or a DM from a random NPUB as you suggest Probably kind-17 makes the most sense as otherwise the SIGit DMs could be an attack vector (trick people into visiting a dangerous url) About the link - it should be /sign or /verify depending on whether the target NPUB is the next signer or not

enes commented

2024-10-09 14:41:00 +00:00

Probably kind-17 makes the most sense as otherwise the SIGit DMs could be an attack vector (trick people into visiting a dangerous url)

Did you mean
https://github.com/nostr-protocol/nips/blob/master/17.md
or
https://github.com/nostr-protocol/nips/blob/master/25.md#reactions-to-a-website or

About the link - it should be /sign or /verify depending on whether the target NPUB is the next signer or not

Ah, it's not just final signer. So, just to make sure I've understood everything, after each signing, we are sending a DM.
If there's a next signer, we send a single DM with link to /sign, and if it's a final signer we notify everyone with /verify link (creator, signers and viewers)?

This is how it looks in coracle for the quick test (nip04)

> Probably kind-17 makes the most sense as otherwise the SIGit DMs could be an attack vector (trick people into visiting a dangerous url) > Did you mean https://github.com/nostr-protocol/nips/blob/master/17.md or https://github.com/nostr-protocol/nips/blob/master/25.md#reactions-to-a-website or > About the link - it should be /sign or /verify depending on whether the target NPUB is the next signer or not > Ah, it's not just final signer. So, just to make sure I've understood everything, after each signing, we are sending a DM. If there's a next signer, we send a single DM with link to `/sign`, and if it's a final signer we notify everyone with `/verify` link (creator, signers and viewers)? This is how it looks in coracle for the quick test (nip04) <img width="454" alt="image" src="attachments/1032c376-9906-4d68-b1b6-fb1a6f1ac6d9">

image.png

15 KiB

b commented

2024-10-09 20:31:45 +00:00

Sorry yeah, NIP-17 not kind-17 lol

We should send the creator and the signer a message after every signature (/sign or /verify depending on status). If it's a final signature then it would be sent to everyone (creator, signers, viewers, /verify only)

Sorry yeah, NIP-17 not kind-17 lol We should send the creator and the signer a message after every signature (`/sign` or `/verify` depending on status). If it's a final signature then it would be sent to everyone (creator, signers, viewers, `/verify` only)

👍 1

enes referenced a pull request that will close this issue

2024-10-14 10:49:04 +00:00

wip: Send dm on sigit sign/complete #230

enes added the

labels 2024-10-14 11:50:08 +00:00

enes added a new dependency 2024-10-14 11:51:41 +00:00