sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

Final DM (SIGit complete) not being sent #92

New Issue
Open
opened 2024-05-29 09:54:19 +00:00 by b · 5 comments
b commented 2024-05-29 09:54:19 +00:00
Owner
Copy Link

When the final signer has signed, the notification email (SIGit complete + link) is not being sent

When the final signer has signed, the notification email (SIGit complete + link) is not being sent
b changed title from Final email (SIGit complete) not being sent to Final DM (SIGit complete) not being sent 2024-05-29 15:06:26 +00:00
enes self-assigned this 2024-10-09 12:29:06 +00:00
enes commented 2024-10-09 12:34:32 +00:00
Member
Copy Link

@b

  1. Do we want to have a link to the /sign or a /verify in the DM?
  2. Should we send the DM as the user (last signer) or generate random private key for sending?
@b 1. Do we want to have a link to the /sign or a /verify in the DM? 2. Should we send the DM as the user (last signer) or generate random private key for sending?
b commented 2024-10-09 13:07:04 +00:00
Author
Owner
Copy Link

We can't send a kind 4 DM as the signer, as that would leak a relationship between the signers

We should either send gift-wrapped DMs or a DM from a random NPUB as you suggest

Probably kind-17 makes the most sense as otherwise the SIGit DMs could be an attack vector (trick people into visiting a dangerous url)

About the link - it should be /sign or /verify depending on whether the target NPUB is the next signer or not

We can't send a kind 4 DM as the signer, as that would leak a relationship between the signers We should either send gift-wrapped DMs or a DM from a random NPUB as you suggest Probably kind-17 makes the most sense as otherwise the SIGit DMs could be an attack vector (trick people into visiting a dangerous url) About the link - it should be /sign or /verify depending on whether the target NPUB is the next signer or not
enes commented 2024-10-09 14:41:00 +00:00
Member
Copy Link

Probably kind-17 makes the most sense as otherwise the SIGit DMs could be an attack vector (trick people into visiting a dangerous url)

Did you mean
https://github.com/nostr-protocol/nips/blob/master/17.md
or
https://github.com/nostr-protocol/nips/blob/master/25.md#reactions-to-a-website or

About the link - it should be /sign or /verify depending on whether the target NPUB is the next signer or not

Ah, it's not just final signer. So, just to make sure I've understood everything, after each signing, we are sending a DM.
If there's a next signer, we send a single DM with link to /sign, and if it's a final signer we notify everyone with /verify link (creator, signers and viewers)?

This is how it looks in coracle for the quick test (nip04)
image

> Probably kind-17 makes the most sense as otherwise the SIGit DMs could be an attack vector (trick people into visiting a dangerous url) > Did you mean https://github.com/nostr-protocol/nips/blob/master/17.md or https://github.com/nostr-protocol/nips/blob/master/25.md#reactions-to-a-website or > About the link - it should be /sign or /verify depending on whether the target NPUB is the next signer or not > Ah, it's not just final signer. So, just to make sure I've understood everything, after each signing, we are sending a DM. If there's a next signer, we send a single DM with link to `/sign`, and if it's a final signer we notify everyone with `/verify` link (creator, signers and viewers)? This is how it looks in coracle for the quick test (nip04) <img width="454" alt="image" src="attachments/1032c376-9906-4d68-b1b6-fb1a6f1ac6d9">
image.png
15 KiB
b commented 2024-10-09 20:31:45 +00:00
Author
Owner
Copy Link

Sorry yeah, NIP-17 not kind-17 lol

We should send the creator and the signer a message after every signature (/sign or /verify depending on status). If it's a final signature then it would be sent to everyone (creator, signers, viewers, /verify only)

Sorry yeah, NIP-17 not kind-17 lol We should send the creator and the signer a message after every signature (`/sign` or `/verify` depending on status). If it's a final signature then it would be sent to everyone (creator, signers, viewers, `/verify` only)
👍 1
enes added the
Kind/Feature
Status
Blocked
Priority
Low
 labels 2024-10-14 11:50:08 +00:00
enes added a new dependency 2024-10-14 11:51:41 +00:00
#229 callbackPath - handleRootRedirect, navigateAfterLogin
enes added a new dependency 2024-10-14 11:51:52 +00:00
#232 Sigit Routing - Add Sigit ID as a Path Param to /verify
endo added this to the MVP project 2025-01-03 13:13:16 +00:00
endo removed the
Status
Blocked
 label 2025-01-03 13:15:28 +00:00
b moved this to To Do in MVP on 2025-01-10 10:11:50 +00:00
b moved this to To Do in MVP on 2025-01-10 10:14:56 +00:00
b moved this to To Do in MVP on 2025-01-10 10:16:29 +00:00
b moved this to To Do in MVP on 2025-01-10 10:16:42 +00:00
enes moved this to In Progress in MVP on 2025-01-24 09:37:18 +00:00
enes moved this to In Progress in MVP on 2025-01-24 14:07:29 +00:00
enes commented 2025-01-24 14:08:22 +00:00
Member
Copy Link

Blocked by #229

Redirect from the DM link is not handled properly and always returns to the home page

Blocked by #229 Redirect from the DM link is not handled properly and always returns to the home page
enes added the
Status
Blocked
 label 2025-01-24 14:08:31 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Kind/Feature
Priority
Low
Status
Blocked
Milestone
No items
No Milestone
Projects
Clear projects
No project MVP
Assignees
Clear assignees
No Assignees enes
2 Participants
Notifications
Due Date
No due date set.
Depends on
#229 callbackPath - handleRootRedirect, navigateAfterLogin
sigit/sigit.io
#232 Sigit Routing - Add Sigit ID as a Path Param to /verify
sigit/sigit.io
Reference: sigit/sigit.io#92
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?