sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

Landing page - new design implementation #122

Merged
b merged 45 commits from issue-21 into staging 2024-07-31 13:06:58 +00:00
Conversation 2 Commits 45 Files Changed 73 +2050 -1080
enes commented 2024-07-30 12:45:31 +00:00
Member
Copy Link

Closes #21

  • Implemented updated design for the homepage
  • Updated main layout
  • Added login/register, login/nostr routes
  • Refactored routes, use generic CustomRoutes and recursiveRouteRenderer for mapping public and private routes
  • Added Footer component
  • Added Container component
  • css/scss refactoring, removed unused

Requested changes:

  • Use FontAwesome package icons
  • Closes #68 - Use set 1 everytime we generate Robo image
  • Add comments to refactored routes
  • Removed and refactored more css/scss
Closes #21 - Implemented updated design for the homepage - Updated main layout - Added `login/register`, `login/nostr` routes - Refactored routes, use generic `CustomRoutes` and `recursiveRouteRenderer` for mapping public and private routes - Added `Footer` component - Added `Container` component - css/scss refactoring, removed unused Requested changes: - Use FontAwesome package icons - Closes #68 - Use set 1 everytime we generate Robo image - Add comments to refactored routes - Removed and refactored more css/scss
enes added 38 commits 2024-07-30 12:45:31 +00:00
enes added 2 commits 2024-07-30 14:25:45 +00:00
enes changed title from WIP: Landing page - new design implementation to Landing page - new design implementation 2024-07-30 14:29:48 +00:00
s requested changes 2024-07-31 07:16:49 +00:00
Dismissed
src/App.scss
@ -0,0 +22,4 @@
--review-feedback-correct: #{$review-feedback-correct};
--review-feedback-incorrect: #{$review-feedback-incorrect};
--review-feedback-neutral: #{$review-feedback-neutral};
--review-feedback-selected-color: #{$review-feedback-selected-color};
s commented 2024-07-31 06:18:46 +00:00
Owner
Copy Link

These variables related to review feedback can be removed. These are leftovers from another repository.

These variables related to review feedback can be removed. These are leftovers from another repository.
👍 1
s marked this conversation as resolved
src/App.tsx Outdated
@ -50,1 +52,4 @@
const publicRoutesList = recursiveRouteRenderer({
routes: publicRoutes,
renderConditionCallback: (r) => {
s commented 2024-07-31 06:42:49 +00:00
Owner
Copy Link

It'll be good to add a comment about renderConditionCallback to explain what it does.

It'll be good to add a comment about `renderConditionCallback` to explain what it does.
👍 1
s marked this conversation as resolved
src/components/username.tsx Outdated
@ -22,2 +18,2 @@
onClick={handleClick}
color="inherit"
<div
style={{
s commented 2024-07-31 06:57:53 +00:00
Owner
Copy Link

This and some of other inline styling in this file can be moved to a separate scss file.

This and some of other inline styling in this file can be moved to a separate scss file.
👍 1
s marked this conversation as resolved
src/pages/landing/index.tsx Outdated
@ -0,0 +20,4 @@
const cards = [
{
icon: (
<svg
s commented 2024-07-31 07:13:24 +00:00
Owner
Copy Link

I know that these icons were provided by the designer like this but I suggest we use fontAwesome library and import the icons and use them in form of components.
Have a look at this

I know that these icons were provided by the designer like this but I suggest we use fontAwesome library and import the icons and use them in form of components. Have a look at [this](https://docs.fontawesome.com/web/use-with/react/)
👍 1
s marked this conversation as resolved
src/routes/index.tsx Outdated
@ -39,0 +55,4 @@
hiddenWhenLoggedIn?: boolean
}>
export function recursiveRouteRenderer<T>({
s commented 2024-07-31 06:41:11 +00:00
Owner
Copy Link

Add some comments about the function.

Add some comments about the function.
👍 1
src/styles/colors.scss Outdated
@ -0,0 +16,4 @@
$review-feedback-correct: #178b13;
$review-feedback-incorrect: #d82222;
$review-feedback-neutral: #f39220;
$review-feedback-selected-color: #fff;
s commented 2024-07-31 06:20:16 +00:00
Owner
Copy Link

These variables related to review feedback can be removed. These are leftovers from another repository.

These variables related to review feedback can be removed. These are leftovers from another repository.
👍 1
enes added 5 commits 2024-07-31 12:37:20 +00:00 
Requested Change
Closes #68 - Only use getRoboHashPicture function (set 1) for Avatars
enes requested review from s 2024-07-31 12:45:51 +00:00
s approved these changes 2024-07-31 12:54:58 +00:00
b merged commit 5445120511 into staging 2024-07-31 13:06:58 +00:00
b deleted branch issue-21 2024-07-31 13:06:58 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
s
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#122
No description provided.
Delete Branch "issue-21"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?