sigit/sigit.io
7
2
Fork 0
Code Issues25 Pull Requests1 Actions Packages Projects1 Releases6 Wiki Activity

CI - Add git hooks and staging checks #128

Merged
enes merged 13 commits from issue-38-90-pipeline-check into staging 2024-08-07 13:54:35 +00:00
Conversation 3 Commits 13 Files Changed 28 +1804 -468
enes commented 2024-08-06 14:24:24 +00:00
Member
  • Add git hooks on package preinstall (pre-commit, commit-msg)
  • Run lint and prettier on staged files with pre-commit hook

Staging workflow:

  • Add lint check
  • Add formatter (prettier) check
  • partially completed
    • include licence checker
    • pre-commit git hook for checking code formatting
  • Closes
    • add audit
    • add licenses list
- Add git hooks on package preinstall (`pre-commit`, `commit-msg`) - Run lint and prettier on staged files with `pre-commit` hook Staging workflow: - Add lint check - Add formatter (prettier) check - #38 partially completed - include licence checker - pre-commit git hook for checking code formatting - Closes #90 - add audit - add licenses list
enes added 5 commits 2024-08-06 14:24:25 +00:00
enes added 1 commit 2024-08-06 14:47:01 +00:00
enes added 2 commits 2024-08-06 15:17:51 +00:00
enes changed title from WIP: CI - Add git hooks and staging checks to CI - Add git hooks and staging checks 2024-08-06 15:18:16 +00:00
enes added 1 commit 2024-08-06 15:26:00 +00:00
enes added 1 commit 2024-08-06 15:39:31 +00:00
enes added 1 commit 2024-08-06 15:44:59 +00:00
enes added 1 commit 2024-08-06 15:49:50 +00:00
enes added 1 commit 2024-08-06 15:54:03 +00:00
enes requested review from m 2024-08-06 15:59:29 +00:00
enes commented 2024-08-06 16:02:24 +00:00
Author
Member

Used the npm run formatter:fix and changed additional 20 src files in the last commit to pass the workflow.

Used the `npm run formatter:fix` and changed additional 20 `src` files in the last commit to pass the workflow.
m approved these changes 2024-08-07 11:32:45 +00:00
src/pages/sign/index.tsx
@ -201,2 +209,3 @@
setCurrentUserMarks(currentUserMarks);
const currentUserMarks = getCurrentUserMarks(metaMarks, signedMarks)
setCurrentUserMarks(currentUserMarks)
// setCurrentUserMark(findNextCurrentUserMark(currentUserMarks) || null)
m commented 2024-08-07 11:31:54 +00:00
Owner

We should remove the comment or explain why we keep it

We should remove the comment or explain why we keep it
enes commented 2024-08-07 13:14:59 +00:00
Author
Member

Removed, it's no longer needed.

Removed, it's no longer needed.
enes added 1 commit 2024-08-07 12:52:03 +00:00
enes force-pushed issue-38-90-pipeline-check from 2f587e9372 to 1297acc7db 2024-08-07 13:49:00 +00:00 Compare
enes commented 2024-08-07 13:51:21 +00:00
Author
Member

Rebased.

Rebased.
enes merged commit c1a6ac246b into staging 2024-08-07 13:54:35 +00:00
enes deleted branch issue-38-90-pipeline-check 2024-08-07 13:54:36 +00:00
Sign in to join this conversation.
No Reviewers
m
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#128
No description provided.
Delete Branch "issue-38-90-pipeline-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?