sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

CI - Add git hooks and staging checks #128

Merged
enes merged 13 commits from issue-38-90-pipeline-check into staging 2024-08-07 13:54:35 +00:00
Conversation 3 Commits 13 Files Changed 28 +1804 -468
enes commented 2024-08-06 14:24:24 +00:00
Member
Copy Link
  • Add git hooks on package preinstall (pre-commit, commit-msg)
  • Run lint and prettier on staged files with pre-commit hook

Staging workflow:

  • Add lint check
  • Add formatter (prettier) check
  • #38 partially completed
    • include licence checker
    • pre-commit git hook for checking code formatting
  • Closes #90
    • add audit
    • add licenses list
- Add git hooks on package preinstall (`pre-commit`, `commit-msg`) - Run lint and prettier on staged files with `pre-commit` hook Staging workflow: - Add lint check - Add formatter (prettier) check - #38 partially completed - include licence checker - pre-commit git hook for checking code formatting - Closes #90 - add audit - add licenses list
enes added 5 commits 2024-08-06 14:24:25 +00:00
enes added 1 commit 2024-08-06 14:47:01 +00:00
enes added 2 commits 2024-08-06 15:17:51 +00:00
fix(ci): run lint-staged always, fix lint-stage commands
Some checks failed
Open PR on Staging / audit_and_check (pull_request) Failing after 28s
Details
ebd392421e
enes changed title from WIP: CI - Add git hooks and staging checks to CI - Add git hooks and staging checks 2024-08-06 15:18:16 +00:00
enes added 1 commit 2024-08-06 15:26:00 +00:00
chore(ci): add license
Some checks failed
Open PR on Staging / audit_and_check (pull_request) Failing after 30s
Details
c3d77d5fa4
enes added 1 commit 2024-08-06 15:39:31 +00:00
enes added 1 commit 2024-08-06 15:44:59 +00:00
ci: add synchronize to PR triggers
Some checks failed
Open PR on Staging / audit_and_check (pull_request) Failing after 32s
Details
8227efa405
enes added 1 commit 2024-08-06 15:49:50 +00:00
chore(lint): increase max warnings to 41
Some checks failed
Open PR on Staging / audit_and_check (pull_request) Failing after 33s
Details
3278f28497
enes added 1 commit 2024-08-06 15:54:03 +00:00
ci(prettier): changes after running npm run formatter:fix
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 32s
Details
d915ea2dbc
enes requested review from m 2024-08-06 15:59:29 +00:00
enes commented 2024-08-06 16:02:24 +00:00
Author
Member
Copy Link

Used the npm run formatter:fix and changed additional 20 src files in the last commit to pass the workflow.

Used the `npm run formatter:fix` and changed additional 20 `src` files in the last commit to pass the workflow.
m approved these changes 2024-08-07 11:32:45 +00:00
src/pages/sign/index.tsx
@ -201,2 +209,3 @@
setCurrentUserMarks(currentUserMarks);
const currentUserMarks = getCurrentUserMarks(metaMarks, signedMarks)
setCurrentUserMarks(currentUserMarks)
// setCurrentUserMark(findNextCurrentUserMark(currentUserMarks) || null)
m commented 2024-08-07 11:31:54 +00:00
Owner
Copy Link

We should remove the comment or explain why we keep it

We should remove the comment or explain why we keep it
enes commented 2024-08-07 13:14:59 +00:00
Author
Member
Copy Link

Removed, it's no longer needed.

Removed, it's no longer needed.
enes added 1 commit 2024-08-07 12:52:03 +00:00
refactor: PR review changes and lint fixes
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 32s
Details
2f587e9372
enes force-pushed issue-38-90-pipeline-check from 2f587e9372 to 1297acc7db 2024-08-07 13:49:00 +00:00 Compare
enes commented 2024-08-07 13:51:21 +00:00
Author
Member
Copy Link

Rebased.

Rebased.
enes merged commit c1a6ac246b into staging 2024-08-07 13:54:35 +00:00
enes deleted branch issue-38-90-pipeline-check 2024-08-07 13:54:36 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
m
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#128
No description provided.
Delete Branch "issue-38-90-pipeline-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?