sigit/sigit.io
7
2
Fork 0
Code Issues 51 Pull Requests 3 Actions Packages Projects 1 Releases Wiki Activity

130-fix-empty-relay-issue #131

Merged
eugene merged 7 commits from 130-fix-empty-relay-issue into staging 2024-08-07 15:27:20 +00:00
Conversation 0 Commits 7 Files Changed 5 +159 -99
eugene commented 2024-08-07 13:09:02 +00:00
Owner
Copy Link

Fixes #30.

Includes a refactor of the relevant section in the MetadataController.

MetadataController and NostrController use different types when dealing with User Relays and going forward it would be good to align approaches. Otto confirmed that it's in the post-MVP roadmap.

Current Limitations

  • The default Sigit relay appears as part of User relays. Instead, it should be separated and a new section should be added called 'App Relay'.
Fixes [#30]([https://git.nostrdev.com/sigit/sigit.io/issues/130]). Includes a refactor of the relevant section in the `MetadataController`. `MetadataController` and `NostrController` use different types when dealing with User Relays and going forward it would be good to align approaches. Otto confirmed that it's in the post-MVP roadmap. **Current Limitations** - The default Sigit relay appears as part of User relays. Instead, it should be separated and a new section should be added called 'App Relay'.
eugene added 2 commits 2024-08-07 13:09:03 +00:00
eugene added 1 commit 2024-08-07 14:43:04 +00:00
eugene added 1 commit 2024-08-07 14:49:21 +00:00
eugene added 2 commits 2024-08-07 14:55:30 +00:00 
This reverts commit 7e420ef583.
Merge branch 'staging' into 130-fix-empty-relay-issue
Some checks failed
Open PR on Staging / audit_and_check (pull_request) Failing after 32s
Details
3f5451b265
enes requested changes 2024-08-07 15:15:25 +00:00
src/utils/const.ts
@ -7,0 +8,4 @@
* Number of milliseconds in one week.
* Calc based on: 7 * 24 * 60 * 60 * 1000
*/
export const ONE_WEEK_IN_MS: number = 604800000
enes commented 2024-08-07 14:28:11 +00:00
Member
Copy Link

we should use this const instead of const oneWeekInMS = 7 * 24 * 60 * 60 * 1000 // Number of milliseconds in one week at

src/controllers/MetadataController.ts Line 130 in c1a6ac246b
const oneWeekInMS = 7 * 24 * 60 * 60 * 1000 // Number of milliseconds in one week

we should use this const instead of `const oneWeekInMS = 7 * 24 * 60 * 60 * 1000 // Number of milliseconds in one week` at https://git.nostrdev.com/sigit/sigit.io/src/commit/c1a6ac246b719739ee7e0eb4d7e09ea10bc64ce1/src/controllers/MetadataController.ts#L130
eugene marked this conversation as resolved
src/utils/relays.ts Outdated
@ -0,0 +6,4 @@
import { RelayMap, RelaySet } from '../types'
const READ_MARKER = "read"
const WRITE_MARKET = "write"
enes commented 2024-08-07 14:21:31 +00:00
Member
Copy Link

small typo

small typo
eugene marked this conversation as resolved
src/utils/relays.ts
@ -0,0 +75,4 @@
[SIGIT_RELAY]: { write: true, read: true }
})
const isOlderThanOneWeek = (cachedAt: number) => {
enes commented 2024-08-07 15:11:37 +00:00
Member
Copy Link

Maybe we can use this function as an util, it's used in MetadataContoller.ts too?

Maybe we can use this function as an util, it's used in `MetadataContoller.ts` too?
eugene marked this conversation as resolved
eugene added 1 commit 2024-08-07 15:24:38 +00:00
refactor: post-PR review changes
Some checks failed
Open PR on Staging / audit_and_check (pull_request) Failing after 33s
Details
2acb353535
eugene merged commit f49a9e0b40 into staging 2024-08-07 15:27:20 +00:00
eugene deleted branch 130-fix-empty-relay-issue 2024-08-07 15:27:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
enes
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sigit/sigit.io#131
No description provided.
Delete Branch "130-fix-empty-relay-issue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?