sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

feat(design): home page new design and functionality #135

Merged
enes merged 24 commits from issue-121 into staging 2024-08-14 08:44:09 +00:00
Conversation 4 Commits 24 Files Changed 36 +1544 -532
enes commented 2024-08-08 15:32:37 +00:00
Member
Copy Link
No description provided.
enes added 17 commits 2024-08-08 15:32:37 +00:00 
Mui modal overrides affected tooltip positioning
feat: add dropzone and multiple files support
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
83ddc1bbc8
enes changed title from feat(design): home page new design and functionality to WIP: feat(design): home page new design and functionality 2024-08-08 15:33:58 +00:00
enes added 2 commits 2024-08-09 09:29:08 +00:00
refactor(home): increase dropzone area
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 32s
Details
15aa98e9db
enes added 1 commit 2024-08-09 10:00:46 +00:00
fix(home): focus outlines and decorations
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
72d0e065ea
enes changed title from WIP: feat(design): home page new design and functionality to feat(design): home page new design and functionality 2024-08-09 10:00:52 +00:00
eugene reviewed 2024-08-09 11:30:18 +00:00
src/hooks/useSigitMeta.tsx Outdated
@ -0,0 +17,4 @@
submittedBy?: string
signers: npub[]
fileExtensions: string[]
signedStatus: SignedStatus
eugene commented 2024-08-09 11:30:18 +00:00
Owner
Copy Link

Should SigitInfo returned by hook also contain other information available in Meta, specifically in the createSignature string, i.e. CreateSIgnatureEventContent? Similarly, should the data from docSignatures, represented by SignedEventContent be returned as well?

I beleive you would need to merge the current staging branch into yours to get a hold of some of these data types

Should `SigitInfo` returned by hook also contain other information available in `Meta`, specifically in the `createSignature` string, i.e. `CreateSIgnatureEventContent`? Similarly, should the data from `docSignatures`, represented by `SignedEventContent` be returned as well? I beleive you would need to merge the current staging branch into yours to get a hold of some of these data types
enes commented 2024-08-12 12:37:07 +00:00
Author
Member
Copy Link

I've returned most of the things I found, we can add if something is missing later down the line 👍

I've returned most of the things I found, we can add if something is missing later down the line 👍
eugene reviewed 2024-08-09 11:34:09 +00:00
eugene left a comment
Owner
Copy Link

Looks good, but I left one comment about the useSigitMeta hook. I believe it should be extended so that it can be used across the full Sigit flow.

Looks good, but I left one comment about the `useSigitMeta` hook. I believe it should be extended so that it can be used across the full Sigit flow.
enes added 1 commit 2024-08-12 12:26:33 +00:00
refactor: expand useSigitMeta and add comments
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
f896849ffd
enes requested review from eugene 2024-08-12 12:37:58 +00:00
enes added 1 commit 2024-08-12 14:02:07 +00:00
chore(git-hooks): clean commit-msg script
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
950593aeed
eugene reviewed 2024-08-13 08:31:48 +00:00
src/hooks/useSigitMeta.tsx
@ -0,0 +68,4 @@
setKind(kind)
setTags(tags)
// created_at in nostr events are stored in seconds
setCreatedAt(created_at * 1000)
eugene commented 2024-08-13 08:31:48 +00:00
Owner
Copy Link

created_at * 1000 should be made into a utility function and used in other similar places (there is at least one that I could find).

Similarly, there is a reverse action, created_at / 1000, which should also be a utility.

`created_at * 1000` should be made into a utility function and used in other similar places (there is at least one that I could find). Similarly, there is a reverse action, `created_at / 1000`, which should also be a utility.
eugene approved these changes 2024-08-13 08:34:00 +00:00
eugene left a comment
Owner
Copy Link

Looks good overall, and good job on adding the Sigit Meta hook.

Looks good overall, and good job on adding the Sigit Meta hook.
enes added 1 commit 2024-08-13 09:52:14 +00:00
refactor(review): add date util functions
Some checks failed
Open PR on Staging / audit_and_check (pull_request) Failing after 9s
Details
6652c6519e
enes added 1 commit 2024-08-14 08:36:01 +00:00
fix(deps): update axios
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 32s
Details
115a3974e2 
Bump axios version to 1.7.4, audit reported the issues in axios >= 1.3.2
enes merged commit b8ba8d0ab4 into staging 2024-08-14 08:44:09 +00:00
enes deleted branch issue-121 2024-08-14 08:44:09 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
eugene
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#135
No description provided.
Delete Branch "issue-121"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?