sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

fix: manage pending relay connection requests #159

Merged
eugene merged 6 commits from reduce-relay-connection-attempts into staging 2024-08-21 08:06:39 +00:00
Conversation 4 Commits 6 Files Changed 10 +124 -160
s commented 2024-08-20 19:17:08 +00:00
Owner
Copy Link

Also remove the getMostPopularRelays function and use a hardcoded list of relays
Further, if metadata event is not found from relays cache an empty metadata for that pubkey

Also remove the getMostPopularRelays function and use a hardcoded list of relays Further, if metadata event is not found from relays cache an empty metadata for that pubkey
s added 1 commit 2024-08-20 19:17:08 +00:00
fix: manage pending relay connection requests
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 34s
Details
f9fcfb1c9e 
Also remove the getMostPopularRelays function and use a hardcoded list of relays
Further, if metadata event is not found from relays cache an empty metadata for that pubkey
s added 1 commit 2024-08-20 19:34:49 +00:00
chore: quick fix
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
2c18c51029
s added 1 commit 2024-08-20 19:43:53 +00:00
fix: in pdf marking if counterpart does not have any of name, displayname, username then show pubkey
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 32s
Details
42d74c656a
eugene reviewed 2024-08-21 06:35:36 +00:00
src/utils/const.ts
@ -15,3 +14,2 @@
*/
export const ONE_WEEK_IN_MS: number = 604800000
export const SIGIT_RELAY: string = 'wss://relay.sigit.io'
export const ONE_WEEK_IN_MS = 7 * 24 * 60 * 60 * 1000
eugene commented 2024-08-21 06:35:36 +00:00
Owner
Copy Link

Why do you need to calculate this constant instead of providing a defined value?

Why do you need to calculate this constant instead of providing a defined value?
b commented 2024-08-21 07:20:21 +00:00
Owner
Copy Link

I guess this avoids any uncertainty about how the number was calculated, or if it was calculated correctly. It's a one time operation right?

I guess this avoids any uncertainty about how the number was calculated, or if it was calculated correctly. It's a one time operation right?
s commented 2024-08-21 07:23:07 +00:00
Author
Owner
Copy Link

yes, its one time.

yes, its one time.
s marked this conversation as resolved
eugene reviewed 2024-08-21 06:40:41 +00:00
src/controllers/MetadataController.ts
@ -132,3 +118,3 @@
if (cachedMetadataEvent) {
// Check if the cached metadata is older than one week
if (isOlderThanOneWeek(cachedMetadataEvent.cachedAt)) {
if (isOlderThanOneDay(cachedMetadataEvent.cachedAt)) {
eugene commented 2024-08-21 06:40:41 +00:00
Owner
Copy Link

There is a discrepancy between the function name and the comments around it. Should it be older than one week or one day?

There is a discrepancy between the function name and the comments around it. Should it be older than one week or one day?
👍 1
s commented 2024-08-21 07:43:24 +00:00
Author
Owner
Copy Link

fixed, Updated comment

fixed, Updated comment
s marked this conversation as resolved
eugene reviewed 2024-08-21 06:43:18 +00:00
src/utils/relays.ts Outdated
@ -196,6 +156,7 @@ const getRelayMap = async (
})
Object.keys(relaysMap).forEach((relayUrl) => {
console.log('being called from getRelayMap')
eugene commented 2024-08-21 06:43:18 +00:00
Owner
Copy Link

Should this console log be removed?

Should this console log be removed?
s commented 2024-08-21 07:43:37 +00:00
Author
Owner
Copy Link

removed

removed
s marked this conversation as resolved
eugene reviewed 2024-08-21 06:43:51 +00:00
src/utils/relays.ts Outdated
@ -256,3 +217,3 @@
// If relay map is empty, use most popular relay URIs
if (!relaysToPublish.length) {
relaysToPublish = await getMostPopularRelays()
relaysToPublish = DEFAULT_LOOK_UP_RELAY_LIST
eugene commented 2024-08-21 06:43:51 +00:00
Owner
Copy Link

Should DEFAULT_LOOK_UP_RELAY_LIST be copied rather than re-assigned?

Should `DEFAULT_LOOK_UP_RELAY_LIST` be copied rather than re-assigned?
s commented 2024-08-21 07:47:20 +00:00
Author
Owner
Copy Link

Its fine here because we're not updating the relaysToPublish array after this assignment in this function (which would have caused side effects on DEFAULT_LOOK_UP_RELAY_LIST).
Further I'm handling the case where I need to append the array by copying the array in the relay controller.

Its fine here because we're not updating the relaysToPublish array after this assignment in this function (which would have caused side effects on DEFAULT_LOOK_UP_RELAY_LIST). Further I'm handling the case where I need to append the array by copying the array in the relay controller.
s marked this conversation as resolved
s added 1 commit 2024-08-21 07:42:15 +00:00
chore: addressed PR comments
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 32s
Details
4a553c047c
b added 1 commit 2024-08-21 07:42:46 +00:00
Merge branch 'staging' into reduce-relay-connection-attempts
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
c1b1c5a075
s added 1 commit 2024-08-21 07:53:30 +00:00
fix: use default relayMap if its undefined in redux store
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
d7b5ea9b9e
eugene merged commit 35f6a639e6 into staging 2024-08-21 08:06:39 +00:00
eugene deleted branch reduce-relay-connection-attempts 2024-08-21 08:06:39 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#159
No description provided.
Delete Branch "reduce-relay-connection-attempts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?