sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

fix: useSigitProfiles dep, map item keys warnining, sign button styles, placeholder, optional button label #160

Merged
enes merged 7 commits from fix-collection-21-8 into staging 2024-08-21 11:15:45 +00:00
Conversation 2 Commits 7 Files Changed 5 +74 -70
enes commented 2024-08-21 09:33:35 +00:00
Member
Copy Link
No description provided.
enes added 5 commits 2024-08-21 09:33:36 +00:00 
Fix issue caused by styles change from 6f88f22933ddd6bf787c69d0dcaf12032d5ea4f9
fix: useSigitProfile dep
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 32s
Details
329fd3d27b 
Remove unecessary dep and disable lint line
enes added 1 commit 2024-08-21 09:37:15 +00:00
refactor(toolbox): make Text default
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 32s
Details
7b33e37ca5
eugene reviewed 2024-08-21 10:49:01 +00:00
src/components/FileList/index.tsx Outdated
@ -42,3 +44,3 @@
</div>
<Button variant="contained" fullWidth onClick={handleDownload}>
Download Files
{downloadLabel ? downloadLabel : 'Download Files'}
eugene commented 2024-08-21 10:49:01 +00:00
Owner
Copy Link

You can probably use the ?? operator. Should Download Files be a constant?

You can probably use the `??` operator. Should `Download Files` be a constant?
s commented 2024-08-21 11:10:05 +00:00
Owner
Copy Link

|| (logical OR) should be used instead of ?? (Nullish Coalescing).
With ?? if downloadLabel is blank string it will return blank but with || we will get default value Download Files

`||` (logical OR) should be used instead of `??` (Nullish Coalescing). With `??` if downloadLabel is blank string it will return blank but with `||` we will get default value `Download Files`
eugene approved these changes 2024-08-21 10:49:28 +00:00
enes added 1 commit 2024-08-21 11:12:10 +00:00
fix: review suggestion
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 33s
Details
15d4d0a752
enes merged commit eb08760f87 into staging 2024-08-21 11:15:45 +00:00
enes deleted branch fix-collection-21-8 2024-08-21 11:15:45 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
eugene
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#160
No description provided.
Delete Branch "fix-collection-21-8"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?