fix: useSigitProfiles dep, map item keys warnining, sign button styles, placeholder, optional button label #160

enes · 2024-08-21T09:33:35Z

enes commented

2024-08-21 09:33:35 +00:00

No description provided.

enes added 5 commits 2024-08-21 09:33:36 +00:00

fix: optional label for download button in filelist 3c230e6fb4

fix: update user placeholder for create e7b0bbe23c

fix: sign buttons styles 8c974768a8

Fix issue caused by styles change from 6f88f22933

fix(verify-page): map item keys 58f70db7f6

fix: useSigitProfile dep

Open PR on Staging / audit_and_check (pull_request) Successful in 32s

Details

329fd3d27b

Remove unecessary dep and disable lint line

enes added 1 commit 2024-08-21 09:37:15 +00:00

refactor(toolbox): make Text default

Open PR on Staging / audit_and_check (pull_request) Successful in 32s

Details

7b33e37ca5

eugene reviewed 2024-08-21 10:49:01 +00:00

src/components/FileList/index.tsx Outdated

						
				@ -42,3 +44,3 @@

				      </div>

				      <Button variant="contained" fullWidth onClick={handleDownload}>

				        Download Files

				        {downloadLabel ? downloadLabel : 'Download Files'}

eugene commented

2024-08-21 10:49:01 +00:00

You can probably use the ?? operator. Should Download Files be a constant?

You can probably use the `??` operator. Should `Download Files` be a constant?

s commented

2024-08-21 11:10:05 +00:00

|| (logical OR) should be used instead of ?? (Nullish Coalescing).
With ?? if downloadLabel is blank string it will return blank but with || we will get default value Download Files

`||` (logical OR) should be used instead of `??` (Nullish Coalescing). With `??` if downloadLabel is blank string it will return blank but with `||` we will get default value `Download Files`