sigit/sigit.io
7
2
Fork 0
Code Issues 51 Pull Requests 3 Actions Packages Projects 1 Releases Wiki Activity

fix: useSigitProfiles dep, map item keys warnining, sign button styles, placeholder, optional button label #160

Merged
enes merged 7 commits from fix-collection-21-8 into staging 2024-08-21 11:15:45 +00:00
Conversation 0 Commits 7 Files Changed 5 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 15d4d0a752 - Show all commits

2
src/components/FileList/index.tsx
View File

@ -43,7 +43,7 @@ const FileList = ({
</ul>
</div>
<Button variant="contained" fullWidth onClick={handleDownload}>
{downloadLabel ? downloadLabel : 'Download Files'}
{downloadLabel || 'Download Files'}
eugene commented 2024-08-21 10:49:01 +00:00
Outdated
Review
Copy Link

You can probably use the ?? operator. Should Download Files be a constant?

You can probably use the `??` operator. Should `Download Files` be a constant?
s commented 2024-08-21 11:10:05 +00:00
Outdated
Review
Copy Link

|| (logical OR) should be used instead of ?? (Nullish Coalescing).
With ?? if downloadLabel is blank string it will return blank but with || we will get default value Download Files

`||` (logical OR) should be used instead of `??` (Nullish Coalescing). With `??` if downloadLabel is blank string it will return blank but with `||` we will get default value `Download Files`
</Button>
</div>
)