sigit/sigit.io
7
2
Fork 0
Code Issues 51 Pull Requests 3 Actions 1 Packages Projects 1 Releases Wiki Activity

fix: useSigitProfiles dep, map item keys warnining, sign button styles, placeholder, optional button label #160

Merged
enes merged 7 commits from fix-collection-21-8 into staging 2024-08-21 11:15:45 +00:00
Conversation 0 Commits 7 Files Changed 5 +5 -2
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3c230e6fb4 - Show all commits

6
src/components/FileList/index.tsx
View File

@ -9,13 +9,15 @@ interface FileListProps {
currentFile: CurrentUserFile currentFile: CurrentUserFile
setCurrentFile: (file: CurrentUserFile) => void setCurrentFile: (file: CurrentUserFile) => void
handleDownload: () => void handleDownload: () => void
downloadLabel?: string
} }
const FileList = ({ const FileList = ({
files, files,
currentFile, currentFile,
setCurrentFile, setCurrentFile,
handleDownload handleDownload,
downloadLabel
}: FileListProps) => { }: FileListProps) => {
const isActive = (file: CurrentUserFile) => file.id === currentFile.id const isActive = (file: CurrentUserFile) => file.id === currentFile.id
return ( return (
@ -41,7 +43,7 @@ const FileList = ({
</ul> </ul>
</div> </div>
<Button variant="contained" fullWidth onClick={handleDownload}> <Button variant="contained" fullWidth onClick={handleDownload}>
Download Files {downloadLabel ? downloadLabel : 'Download Files'}
eugene commented 2024-08-21 10:49:01 +00:00
Outdated
Review
Copy Link

You can probably use the ?? operator. Should Download Files be a constant?

You can probably use the `??` operator. Should `Download Files` be a constant?
s commented 2024-08-21 11:10:05 +00:00
Outdated
Review
Copy Link

|| (logical OR) should be used instead of ?? (Nullish Coalescing).
With ?? if downloadLabel is blank string it will return blank but with || we will get default value Download Files

`||` (logical OR) should be used instead of `??` (Nullish Coalescing). With `??` if downloadLabel is blank string it will return blank but with `||` we will get default value `Download Files`
</Button> </Button>
</div> </div>
) )

1
src/pages/verify/index.tsx
View File

@ -538,6 +538,7 @@ export const VerifyPage = () => {
currentFile={currentFile} currentFile={currentFile}
setCurrentFile={setCurrentFile} setCurrentFile={setCurrentFile}
handleDownload={handleExport} handleDownload={handleExport}
downloadLabel="Download Sigit"
/> />
)} )}
{displayExportedBy()} {displayExportedBy()}