sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

fix: show other file types in the middle section (create, sign, verify) #163

Merged
enes merged 5 commits from 138-other-file-types into staging 2024-08-26 12:00:33 +00:00
Conversation 1 Commits 5 Files Changed 27 +632 -518
enes commented 2024-08-22 17:08:12 +00:00
Member
Copy Link
  • Show placeholder file boxes in the content section even if it's not a .pdf file
  • Render images in the content section
  • Refactor PdfFile into SigitFile and make it more generic to handle additional file types
  • Move common css from module specific files to common App.scss
  • De-duplicate some of the css and code
  • Move functions to more appropriate files (file maniupulation to file, pdf to pdf, etc)
  • Fix DisplaySigit showing multiple file types if there are more file types, instead of more different file types

Closes #138

- Show placeholder file boxes in the content section even if it's not a `.pdf` file - Render images in the content section - Refactor `PdfFile` into `SigitFile` and make it more generic to handle additional file types - Move common css from module specific files to common `App.scss` - De-duplicate some of the css and code - Move functions to more appropriate files (file maniupulation to file, pdf to pdf, etc) - Fix `DisplaySigit` showing multiple file types if there are more file types, instead of more different file types Closes #138
enes added 5 commits 2024-08-22 17:08:13 +00:00 
Closes #138
fix(home-page): sigit file type display now correctly shows multiple file types
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 40s
Details
acc8c84617
s was assigned by enes 2024-08-22 17:08:23 +00:00
s was unassigned by enes 2024-08-22 17:08:25 +00:00
enes requested review from s 2024-08-22 17:08:29 +00:00
s approved these changes 2024-08-26 08:55:05 +00:00
enes merged commit f4aefbb200 into staging 2024-08-26 12:00:33 +00:00
enes deleted branch 138-other-file-types 2024-08-26 12:00:33 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
s
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#163
No description provided.
Delete Branch "138-other-file-types"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?