fix: when decrypting file, have better error messages #17

m · 2024-05-09T13:48:14Z

m commented

2024-05-09 13:48:14 +00:00

Closes #11 #9 #2

m added 1 commit 2024-05-09 13:48:14 +00:00

fix: when decrypting file, have better error messages 5d6a3580a6

m changed title from ~~fix: when decrypting file, have better error messages~~ to WIP: fix: when decrypting file, have better error messages

2024-05-09 13:48:18 +00:00

m added 2 commits 2024-05-13 06:00:55 +00:00

fix: increased timeout for extension user prompt 2c2eeba83f

feat(profile): picture upload, robohash, website, npub cash 041bd0daff

m added 1 commit 2024-05-13 06:02:42 +00:00

chore: lint 413c9cc575

m added 1 commit 2024-05-13 06:24:59 +00:00

chore(git): Merge branch 'main' into issue-11 0cdb5c2136

m changed title from ~~WIP: fix: when decrypting file, have better error messages~~ to fix: when decrypting file, have better error messages

2024-05-13 06:25:04 +00:00

s requested changes 2024-05-13 07:32:54 +00:00

src/pages/profile/index.tsx Outdated

						
				@ -110,0 +126,4 @@

				    let lud16 = ''

				    if (npub) {

				      if (npub) lud16 = `${npub}@npub.cash`

s commented

2024-05-13 07:31:31 +00:00

second if is uncessary

m marked this conversation as resolved

m added 1 commit 2024-05-13 07:52:12 +00:00

chore: removed sufficient if 1fbc2414fe

m added 1 commit 2024-05-13 08:11:46 +00:00

chore: media server protocol fix, removed npub cash 2221b22285

m added 1 commit 2024-05-14 12:39:13 +00:00

fix: removing file upload, avatar by robohash 8e7620201e

y requested changes 2024-05-14 13:16:41 +00:00

Dismissed

src/controllers/NostrController.ts Outdated

						
				@ -362,0 +362,4 @@

				  /**

				 * Creates Nostr HTTP Auth token

				 * @param npub npub in hex format

y commented

2024-05-14 12:52:45 +00:00

createNostrHttpAuthToken method has only one param

`createNostrHttpAuthToken` method has only one param

m marked this conversation as resolved

src/controllers/NostrController.ts Outdated

						
				@ -362,0 +376,4 @@

				  authEvent.content = `sigit-${createdAt}`

				  authEvent.created_at = createdAt

				  await this.signEvent(authEvent.rawEvent() as UnsignedEvent)

y commented

2024-05-14 12:57:18 +00:00

signEvent method returns a promise that resolves into signed event, and I think you should assign it to signedAuthEvent constant

`signEvent` method returns a promise that resolves into signed event, and I think you should assign it to `signedAuthEvent` constant

m marked this conversation as resolved

src/controllers/NostrController.ts Outdated

						
				@ -362,0 +391,4 @@

				    const token = btoa(authEventSerialized)

				    return token

				  } catch (error) {

				    throw new Error('An error occurred in JSON.stringy of signedAuthEvent')

y commented

2024-05-14 12:59:54 +00:00

I would change the error message to An error occurred while encoding signed auth event.

I would change the error message to `An error occurred while encoding signed auth event.`

m marked this conversation as resolved

src/pages/decrypt/index.tsx

						
				@ -64,2 +64,3 @@

				      console.log('err in decryption:>> ', err)

				      toast.error(err.message || 'An error occurred while decrypting file.')

				      if (err.message.toLowerCase().includes('expected')) {

y commented

2024-05-14 13:10:17 +00:00

I would say that a more convenient and reliable approach to handle errors is to have dedicated errors of custom type

m marked this conversation as resolved

src/pages/decrypt/index.tsx Outdated

						
				@ -65,1 +65,3 @@

				      toast.error(err.message || 'An error occurred while decrypting file.')

				      if (err.message.toLowerCase().includes('expected')) {

				        toast.error(`The Key seems to be invalid length or format`)

y commented

2024-05-14 13:12:05 +00:00

The message should be The decryption key length or format is invalid.

The message should be `The decryption key length or format is invalid.`

m marked this conversation as resolved

src/pages/decrypt/index.tsx Outdated

						
				@ -66,0 +66,4 @@

				      if (err.message.toLowerCase().includes('expected')) {

				        toast.error(`The Key seems to be invalid length or format`)

				      } else if (err.message.includes('The JWK "alg" member was inconsistent')) {

				        toast.error(`The Key seems to be invalid.`)