sigit/sigit.io
6
2
Fork 0
Code Issues 55 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

fix: when decrypting file, have better error messages #17

Merged
b merged 11 commits from issue-11 into main 2024-05-14 15:09:01 +00:00
Conversation 0 Commits 11 Files Changed 8 +9 -1
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5d6a3580a6 - Show all commits

10
src/pages/decrypt/index.tsx
View File

@ -62,7 +62,15 @@ export const DecryptZip = () => {
encryptionKey encryptionKey
).catch((err) => { ).catch((err) => {
console.log('err in decryption:>> ', err) console.log('err in decryption:>> ', err)
toast.error(err.message || 'An error occurred while decrypting file.')
if (err.message.toLowerCase().includes('expected')) {
m marked this conversation as resolved
y commented 2024-05-14 13:10:17 +00:00
Review
Copy Link

I would say that a more convenient and reliable approach to handle errors is to have dedicated errors of custom type

I would say that a more convenient and reliable approach to handle errors is to have dedicated errors of custom type
toast.error(`The Key seems to be invalid length or format`)
m marked this conversation as resolved Outdated
y commented 2024-05-14 13:12:05 +00:00
Outdated
Review
Copy Link

The message should be The decryption key length or format is invalid.

The message should be `The decryption key length or format is invalid.`
} else if (err.message.includes('The JWK "alg" member was inconsistent')) {
toast.error(`The Key seems to be invalid.`)
m marked this conversation as resolved Outdated
y commented 2024-05-14 13:12:37 +00:00
Outdated
Review
Copy Link

The message should be The decryption key is invalid.

The message should be `The decryption key is invalid.`
} else {
toast.error(err.message || 'An error occurred while decrypting file.')
}
setIsLoading(false) setIsLoading(false)
return null return null
}) })