Extension login infinite loading #198

enes · 2024-09-12T07:58:22Z

enes commented

2024-09-12 07:58:22 +00:00

The user was unable to log in with an older/unsupported nostr extension which caused the infinite loading.

This PR's intent is to add a fallback and a timeout for such cases where extensions are not responding within a certain timeframe.

To that end, we:

introduced the EXTENSION_LOGIN_DELAY_SECONDS (the delay after initial login press after which we assume extension is taking longer than usual) and EXTENSION_LOGIN_TIMEOUT_SECONDS (the actual timeout) which interrupts login attempt and gives back control to the user.
expanded LoadingSpinner, it can optionally include child component, i.e Button to manually interrupt the loading
custom TimeoutError which we can type check against and log the error

Additionally, we updated the isOnline detection to self-ping (localhost will cause false positives). The online detection will be updated with the new offline flow features.

Closes #196

The user was unable to log in with an older/unsupported nostr extension which caused the infinite loading. This PR's intent is to add a fallback and a timeout for such cases where extensions are not responding within a certain timeframe. To that end, we: - introduced the `EXTENSION_LOGIN_DELAY_SECONDS` (the delay after initial login press after which we assume extension is taking longer than usual) and `EXTENSION_LOGIN_TIMEOUT_SECONDS` (the actual timeout) which interrupts login attempt and gives back control to the user. - expanded `LoadingSpinner`, it can optionally include child component, i.e `Button` to manually interrupt the loading - custom `TimeoutError` which we can type check against and log the error Additionally, we updated the `isOnline` detection to self-ping (`localhost` will cause false positives). The online detection will be updated with the new offline flow features. Closes #196

enes added 4 commits 2024-09-12 07:58:23 +00:00

fix(loading): make sure the default spinner is absolute relative to root always 4bc5882ab6

feat(loading-spinner): add children support for default variant 4d1e672268

fix(errors): add custom timeout error 9c545a477c

fix(login): extension login infinite loading

Open PR on Staging / audit_and_check (pull_request) Successful in 34s

Details

7c80643aba