fix(pdf): pdf quality and multiline #204
No reviewers
Labels
No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sigit/sigit.io#204
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "176-178-pdf-quality-multiline"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR solves two issues #176 and #178 with the usage of pdf-lib's
drawText
method.The method embeds the text into the pdf itself (no loss of quality was observed) and handles multiline text out of the box.
Small adjustments were made to the text positioning logic:
top
left
point of the mark location.label
) that allows us to easily place text exactly where we want it.Additional changes:
Arial
toRoboto
(custom font is embedded with@pdf-lib/fontkit
into the pdf itself asttf
with increased character support, existingwoff2
andwoff
were lacking some characters after embedding)Looks good!