sigit/sigit.io
7
2
Fork 0
Code Issues25 Pull Requests Actions Packages Projects1 Releases6 Wiki Activity

issue-166-open-timestamps #220

Merged
eugene merged 25 commits from issue-166-open-timestamps into staging 2024-10-25 11:18:47 +00:00
Conversation 1 Commits 25 Files Changed 16 +517 -17
eugene commented 2024-10-07 15:27:17 +00:00
Owner

Description of the full Open Timestamps Flow

  1. On create, a new (incomplete) timestamp is created for the nostrId of the original CreateSignatureEvent. It is stored in the timestamps array on the Meta object. No further signature is added to the timestamp.

  2. On signing, a new (incomplete) timestamp is created for the nostrId of the DocSignature event and is stored in the same timestamps array on Meta.No further signatures or checks are performed.

  3. When the user go to the verify page, Sigit will try to upgrade the available timestamps. If no upgrade is currently available (i.e., the timestamp has not been posted on the Bitcoin blockchain yet), nothing happens.

    If an upgrade is available, the timestamp will be available and a nostr event will 'sign' the timestamp completion. The nostr signature will be added to the timestamp object.

    Then, the user will need to sign another event, updating app data and sending notifications to other users.

    Note that if more than one timestamp can be updated at the same time, it will be done with just one nostr event, and the finished timestamp will contain the same signature.

  4. The final timestamp should include the timestamp itself with several Bitcoin attestations, the nostr event that signed its completion, and a nostrId - which is related to the nostr event action that the timestamp verified (i.e. create or sign).

**Description of the full Open Timestamps Flow** 1. On create, a new (incomplete) timestamp is created for the nostrId of the original CreateSignatureEvent. It is stored in the timestamps array on the Meta object. No further signature is added to the timestamp. 2. On signing, a new (incomplete) timestamp is created for the nostrId of the DocSignature event and is stored in the same timestamps array on Meta.No further signatures or checks are performed. 3. When the user go to the verify page, Sigit will try to upgrade the available timestamps. If no upgrade is currently available (i.e., the timestamp has not been posted on the Bitcoin blockchain yet), nothing happens. If an upgrade is available, the timestamp will be available and a nostr event will 'sign' the timestamp completion. The nostr signature will be added to the timestamp object. Then, the user will need to sign another event, updating app data and sending notifications to other users. Note that if more than one timestamp can be updated at the same time, it will be done with just one nostr event, and the finished timestamp will contain the same signature. 4. The final timestamp should include the timestamp itself with several Bitcoin attestations, the nostr event that signed its completion, and a nostrId - which is related to the nostr event action that the timestamp verified (i.e. create or sign).
eugene added the
Kind/Feature
 label 2024-10-07 15:27:17 +00:00
enes was assigned by eugene 2024-10-07 15:27:17 +00:00
eugene added 15 commits 2024-10-07 15:27:18 +00:00 
Reviewed-on:
eugene added 1 commit 2024-10-08 15:01:55 +00:00
eugene added 1 commit 2024-10-08 15:04:10 +00:00
eugene added 4 commits 2024-10-24 09:43:49 +00:00
eugene added 1 commit 2024-10-24 09:54:52 +00:00
enes approved these changes 2024-10-25 09:05:03 +00:00
enes left a comment
Member

Looks good, just two nitpicky html/css comments. It would be nice to match the padding and make it work without extra span wrapper.

Looks good, just two nitpicky html/css comments. It would be nice to match the padding and make it work without extra span wrapper.
src/components/UsersDetails.tsx/index.tsx Outdated
@ -54,0 +69,4 @@
nostrId: string
) => {
if (isTimestampVerified(timestamps, nostrId)) {
return <FontAwesomeIcon icon={faCheck} />
enes commented 2024-10-25 09:03:35 +00:00
Member

Can we make add the className={styles.ticket}> to the icon directly here instead of wrapping the SVG in the code below?

Can we make add the `className={styles.ticket}>` to the icon directly here instead of wrapping the SVG in the code below?
eugene marked this conversation as resolved
src/components/UsersDetails.tsx/style.module.scss
@ -47,0 +45,4 @@
.ticket {
margin-left: auto;
}
enes commented 2024-10-25 09:02:19 +00:00
Member

Tiny styling improvement, 5px padding to match the first icon.

Tiny styling improvement, 5px padding to match the first icon.
eugene marked this conversation as resolved
eugene added 2 commits 2024-10-25 09:39:08 +00:00 
Reviewed-on:
eugene added 1 commit 2024-10-25 10:13:28 +00:00
eugene added 1 commit 2024-10-25 11:15:20 +00:00
eugene merged commit aae11589a4 into staging 2024-10-25 11:18:47 +00:00
eugene deleted branch issue-166-open-timestamps 2024-10-25 11:18:47 +00:00
Sign in to join this conversation.
No Reviewers
enes
No Label
Kind/Feature
No Milestone
No project
No Assignees enes
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#220
No description provided.
Delete Branch "issue-166-open-timestamps"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?