squiggle with signature-pad and smoother lines + blossom #258

enes · 2024-11-18T17:06:08Z

enes commented

2024-11-18 17:06:08 +00:00

This PR replaces the signature type drawing.
The squiggle now uses signature_pad package and has smoother lines. Due to size implications of more detailed signature the underlying data is encrypted and uploaded to the blossom server.

The updated logic is now following strategy like pattern for the toolbox/mark types with each tool having a Input and Render components with optional fetchAndDecrypt, encryptAndUpload functions.

#242

TODO:

- offline support (postponed)
-> verify signature

Signature data should also be verified on the verify page (make sure the hash of the file is the hash in the meta.json)

-> Double check exporting

When exporting (encrypted or not) we should include the signature data in the files folder in the zipped file (HASH.json)`)

This PR replaces the signature type drawing. The squiggle now uses `signature_pad` package and has smoother lines. Due to size implications of more detailed signature the underlying data is encrypted and uploaded to the blossom server. The updated logic is now following strategy like pattern for the toolbox/mark types with each tool having a `Input` and `Render` components with optional `fetchAndDecrypt`, `encryptAndUpload` functions. https://git.nostrdev.com/sigit/sigit.io/issues/242 TODO: - [x] - offline support (postponed) - [x] -> verify signature >Signature data should also be verified on the verify page (make sure the hash of the file is the hash in the meta.json) - [x] -> Double check exporting >When exporting (encrypted or not) we should include the signature data in the files folder in the zipped file (HASH.json)`)

enes added 10 commits 2024-11-18 17:06:08 +00:00

refactor: use signature pad, smoother signature line 7c7a222d4f

BREAKING CHANGE: mark.value type changed

refactor(signature): fixed pad size, scale to fit mark 6fd5014302

refactor(signature): stretch svg render 7fa9a008fa

refactor(signature): use reduced point group data 3f081c1632

feat(signature): signature pad encrypt, upload, fetch, decrypt, render, add to pdf 9551750cbe

feat(signature): export signature files cdf26b6614

fix(signature): force re-render on value change a1c308727f

refactor(signature): save only decrypted signature files on export f72ad37ec0

refactor(signature): apply strategy pattern and make it easier to expand with new tools be146fa0fa

build(vite): fix hmr circular reference warning

Open PR on Staging / audit_and_check (pull_request) Successful in 38s

Details

206169dbaa

enes added 1 commit 2024-11-22 12:30:26 +00:00

chore(git): merge branch 'staging' into feat/signature-pad

Open PR on Staging / audit_and_check (pull_request) Successful in 38s

Details

3255e93121

enes added 1 commit 2024-11-22 16:14:14 +00:00

feat(signature): verify hash

Open PR on Staging / audit_and_check (pull_request) Successful in 38s

Details

a371e98e9e

enes changed title from ~~wip: squiggle with signature-pad and smoother lines + blossom~~ to squiggle with signature-pad and smoother lines + blossom

2024-11-22 16:27:06 +00:00

m approved these changes 2024-11-26 09:33:39 +00:00

m left a comment

I am loving the new Mark Architecture!

I am loving the new `Mark` Architecture!

enes merged commit 760ac176e8 into staging

2024-11-26 09:35:44 +00:00

enes deleted branch feat/signature-pad

2024-11-26 09:35:45 +00:00

enes referenced this issue from a commit

2024-11-26 09:35:46 +00:00

chore(git): merge pull request #258 from feat/signature-pad into staging