sigit/sigit.io
7
2
Fork 0
Code Issues 46 Pull Requests 6 Actions Packages Projects 1 Releases Wiki Activity

Remove small drawn fields #264

Merged
enes merged 3 commits from issue-234-empty-box-creation into staging 2024-11-29 14:41:16 +00:00
Conversation 0 Commits 3 Files Changed 4 +32 -9
enes commented 2024-11-29 11:21:53 +00:00
Member
Copy Link

Remove small drawn fields accidentally created by clicking on the pdf if either the width or height is smaller than MINIMUM_RECT_SIZE. The current size is 21x21 (arbitrarily based on the avatar size).

Additionally fix a small CSS issue causing the mark text to be centered contrary to the actual text location (top left corner) in pdf.

Remove small drawn fields accidentally created by clicking on the pdf if either the width or height is smaller than `MINIMUM_RECT_SIZE`. The current size is 21x21 (arbitrarily based on the avatar size). Additionally fix a small CSS issue causing the mark text to be centered contrary to the actual text location (top left corner) in pdf.
enes added 2 commits 2024-11-29 11:21:53 +00:00
fix(create): remove small drawn fields
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 38s
Details
902ad73faf 
Closes #234
enes requested review from m 2024-11-29 11:22:05 +00:00
enes added 1 commit 2024-11-29 11:45:47 +00:00
refactor(create): update comment
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 38s
Details
6193c20ac3
s approved these changes 2024-11-29 13:52:55 +00:00
enes merged commit 55e2e6e35a into staging 2024-11-29 14:41:16 +00:00
enes deleted branch issue-234-empty-box-creation 2024-11-29 14:41:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
m
s
Labels
Clear labels   
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sigit/sigit.io#264
No description provided.
Delete Branch "issue-234-empty-box-creation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?