sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

feat: Sign Directly From the Marking Screen fix: Marking inputs glitches, losing values #272

Merged
b merged 7 commits from issue-173 into staging 2024-12-10 15:34:01 +00:00
Conversation 2 Commits 7 Files Changed 9 +367 -323
m commented 2024-12-06 12:27:01 +00:00
Owner
Copy Link

Closes #173

Closes #173
m added 1 commit 2024-12-06 12:27:02 +00:00
feat: Sign Directly From the Marking Screen fix: Marking inputs glitches, losing values
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 46s
Details
0a0a9bef34
m added 1 commit 2024-12-06 12:27:11 +00:00
Merge branch 'staging' into issue-173
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 41s
Details
241d0cc79c
enes reviewed 2024-12-06 17:44:07 +00:00
src/components/FileList/index.tsx Outdated
@ -46,2 +49,2 @@
{downloadLabel || 'Download Files'}
</Button>
{!downloadLabel && (
enes commented 2024-12-06 17:27:30 +00:00
Member
Copy Link

Do we need the downloadLabel at all? Especially as a condition here, it's a bit confusing.

Do we need the `downloadLabel` at all? Especially as a condition here, it's a bit confusing.
m marked this conversation as resolved
src/components/FileList/index.tsx Outdated
@ -48,0 +66,4 @@
<MenuItem
onClick={() => {
popupState.close
handleEncryptedExport && handleEncryptedExport()
enes commented 2024-12-06 17:29:34 +00:00
Member
Copy Link

Would it be safer to check for typeof handleEncryptedExport === "function"?

Would it be safer to check for `typeof handleEncryptedExport === "function"`?
m marked this conversation as resolved
src/pages/sign/index.tsx Outdated
@ -803,4 +698,1 @@
return signerIndex === lastSignerIndex
}
const handleExport = async () => {
enes commented 2024-12-06 17:36:43 +00:00
Member
Copy Link

I believe every export (both types and both sign and verify) should include exportSignature, @b correct me if I'm wrong.

I believe every export (both types and both sign and verify) should include `exportSignature`, @b correct me if I'm wrong.
b commented 2024-12-06 18:35:24 +00:00
Owner
Copy Link

correct

correct
m marked this conversation as resolved
m added 2 commits 2024-12-06 19:24:02 +00:00
chore(git): merge
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 45s
Details
fc8f73962b
m added 3 commits 2024-12-10 13:47:30 +00:00
fix: removed redundant variable
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 45s
Details
245585662a
m requested review from enes 2024-12-10 14:35:12 +00:00
enes approved these changes 2024-12-10 15:06:05 +00:00
b merged commit 80dd597ada into staging 2024-12-10 15:34:01 +00:00
b deleted branch issue-173 2024-12-10 15:34:01 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
enes
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#272
No description provided.
Delete Branch "issue-173"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?