chore: use-ndk #283

s · 2024-12-22T18:40:22Z

s commented

2024-12-22 18:40:22 +00:00

Implemented NDKContext that will be used for relays-related operation.
replaced AuthController with custom useAuth hook.
replaced dvm utils files with useDVM custom hook.
removed RelayController and MetadataController in favour of NDKContext
deprecated ProfileMetadata in favor of NDKUserProfile

* Implemented NDKContext that will be used for relays-related operation. * replaced `AuthController` with custom `useAuth` hook. * replaced dvm utils files with `useDVM` custom hook. * removed `RelayController` and `MetadataController` in favour of `NDKContext` * deprecated `ProfileMetadata` in favor of `NDKUserProfile`

s added 8 commits 2024-12-22 18:40:22 +00:00

feat: added ndkContext and used it in relays page 3c061d5920

chore(refactor): use NDKContext in profile page 2248128001

chore(refactor): replace authContoller with useAuth hook 0cc1a32059

chore(refactore): use NDKContext for findMetadata instead of metadata controller 458de18f12

chore(refactor): use getNDKRelayList function from NDKContext instead of findRelayListMetadata function of metadata controller 5c24c5bde0

chore: include sigit relay explicitly when fetching event from user relays 3615de70ad

chore: remove dvm utils file and use useDvm hook instead 0ea6ba0033

chore: removed relay controller in favor of NDKContext

Open PR on Staging / audit_and_check (pull_request) Successful in 47s

Details

e8a53bc73e

s added 2 commits 2024-12-27 12:21:34 +00:00

chore: merge stating into use-ndk 4e54d12175

chore: remove import of deleted file

Open PR on Staging / audit_and_check (pull_request) Successful in 40s

Details

4f9fdd19b0

s added 2 commits 2024-12-27 19:44:33 +00:00

chore: fix fetching of user profile 006ed7b548

chore: fix issue in publishing sigit

Open PR on Staging / audit_and_check (pull_request) Successful in 45s

Details

01bb68d87b

s added 1 commit 2024-12-28 09:57:32 +00:00

chore: replace the usage of ProfileMetadata with NDKUserProfile

Open PR on Staging / audit_and_check (pull_request) Successful in 46s

Details

95f5398736

s changed title from ~~WIP: use-ndk~~ to use-ndk

2024-12-30 10:17:23 +00:00

s changed title from ~~use-ndk~~ to chore: use-ndk

2024-12-30 10:17:44 +00:00

enes reviewed 2024-12-30 12:04:51 +00:00

src/components/DrawPDFFields/internal/Counterpart.tsx

						
				@ -26,3 +27,3 @@

				        <div className={styles.counterpartSelectValue}>

				          <AvatarIconButton

				            src={signerMetadata.picture}

				            src={profile.image}

enes commented

2024-12-30 11:56:17 +00:00

Had this error during test on Create page: Uncaught TypeError: Cannot read properties of undefined (reading 'image') after selecting DrawnField rect.

Steps:

Create a new sigit, add files, and after navigating to Create Page
Add field with any tool
Click the box - error

Had this error during test on Create page: `Uncaught TypeError: Cannot read properties of undefined (reading 'image')` after selecting `DrawnField` rect. Steps: 1. Create a new sigit, add files, and after navigating to `Create Page` 2. Add field with any tool 3. Click the box - error

s commented

2025-01-04 06:50:23 +00:00

I tested multiple times and it worked every time

src/contexts/NDKContext.tsx

						
				@ -0,0 +67,4 @@

				  }, [])

				  const ndk = useMemo(() => {

				    localStorage.setItem('debug', '*')

enes commented

2024-12-30 11:14:34 +00:00

We should probably have debug off or control it with ENV for production.

s marked this conversation as resolved

src/hooks/useNDK.ts Outdated

						
				@ -0,0 +457,4 @@

				      const ndkRelayList = await getNDKRelayList(receiver)

				      const readRelayUrls = [...ndkRelayList.readRelayUrls]

enes commented

2024-12-30 12:04:07 +00:00

Had this error after completing a sigit (error types here don't indicate undefined to be a possibility) and after timestamp upgrades triggered.

TypeError: Cannot read properties of undefined (reading 'readRelayUrls')
    at useNDK.ts:460:46
    at async Promise.all (:5173/index 0)
    at async upgradeT (index.tsx:383:11)```

Had this error after completing a sigit (error types here don't indicate `undefined` to be a possibility) and after timestamp upgrades triggered. ``` TypeError: Cannot read properties of undefined (reading 'readRelayUrls') at useNDK.ts:460:46 at async Promise.all (:5173/index 0) at async upgradeT (index.tsx:383:11)```

s commented

2025-01-04 06:46:57 +00:00

I tried multiple sigit rounds, but couldn't reproduce this issue.

src/store/user/reducer.ts Outdated

						
				@ -0,0 +23,4 @@

				        profile: action.payload

				      }

				    // case ActionTypes.RESTORE_STATE:

enes commented

2024-12-30 11:42:43 +00:00

Are we intentionally skipping restoration of the user state?

s commented

2025-01-04 06:37:15 +00:00

It wasn't intentional, fixed

s marked this conversation as resolved

s added 2 commits 2025-01-04 06:26:36 +00:00

chore: handle restore state action in user reducer c4c0ecba4a

chore: process received events all together instead of one by one which casuses in-consistencies due to async nature of redux updates

Open PR on Staging / audit_and_check (pull_request) Successful in 44s

Details

3a09d4c595

s added 1 commit 2025-01-04 06:34:01 +00:00

chore: enable debug logs only in dev mode

Open PR on Staging / audit_and_check (pull_request) Successful in 41s

Details

0d93e16f3a

s added 1 commit 2025-01-04 07:21:55 +00:00

chore: merge staging into use-ndk

Open PR on Staging / audit_and_check (pull_request) Successful in 44s

Details

14c103dd40

Open PR on Staging / audit_and_check (pull_request) Successful in 44s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin use-ndk:use-ndk

git checkout use-ndk

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sigit/sigit.io#283