sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases 5 Wiki Activity

chore: use-ndk #283

Merged
s merged 18 commits from use-ndk into staging 2025-01-06 11:10:49 +00:00
Conversation 1 Commits 18 Files Changed 49 +1743 -2316
s commented 2024-12-22 18:40:22 +00:00
Owner
Copy Link
  • Implemented NDKContext that will be used for relays-related operation.
  • replaced AuthController with custom useAuth hook.
  • replaced dvm utils files with useDVM custom hook.
  • removed RelayController and MetadataController in favour of NDKContext
  • deprecated ProfileMetadata in favor of NDKUserProfile
* Implemented NDKContext that will be used for relays-related operation. * replaced `AuthController` with custom `useAuth` hook. * replaced dvm utils files with `useDVM` custom hook. * removed `RelayController` and `MetadataController` in favour of `NDKContext` * deprecated `ProfileMetadata` in favor of `NDKUserProfile`
s added 8 commits 2024-12-22 18:40:22 +00:00
chore: removed relay controller in favor of NDKContext
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 47s
Details
e8a53bc73e
s added 2 commits 2024-12-27 12:21:34 +00:00
chore: remove import of deleted file
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 40s
Details
4f9fdd19b0
s added 2 commits 2024-12-27 19:44:33 +00:00
chore: fix issue in publishing sigit
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 45s
Details
01bb68d87b
s added 1 commit 2024-12-28 09:57:32 +00:00
chore: replace the usage of ProfileMetadata with NDKUserProfile
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 46s
Details
95f5398736
s changed title from WIP: use-ndk to use-ndk 2024-12-30 10:17:23 +00:00
s changed title from use-ndk to chore: use-ndk 2024-12-30 10:17:44 +00:00
enes reviewed 2024-12-30 12:04:51 +00:00
src/components/DrawPDFFields/internal/Counterpart.tsx Outdated
@ -26,3 +27,3 @@
<div className={styles.counterpartSelectValue}>
<AvatarIconButton
src={signerMetadata.picture}
src={profile.image}
enes commented 2024-12-30 11:56:17 +00:00
Member
Copy Link

Had this error during test on Create page: Uncaught TypeError: Cannot read properties of undefined (reading 'image') after selecting DrawnField rect.

Steps:

  1. Create a new sigit, add files, and after navigating to Create Page
  2. Add field with any tool
  3. Click the box - error
Had this error during test on Create page: `Uncaught TypeError: Cannot read properties of undefined (reading 'image')` after selecting `DrawnField` rect. Steps: 1. Create a new sigit, add files, and after navigating to `Create Page` 2. Add field with any tool 3. Click the box - error
s commented 2025-01-04 06:50:23 +00:00
Author
Owner
Copy Link

I tested multiple times and it worked every time

I tested multiple times and it worked every time
src/contexts/NDKContext.tsx
@ -0,0 +67,4 @@
}, [])
const ndk = useMemo(() => {
localStorage.setItem('debug', '*')
enes commented 2024-12-30 11:14:34 +00:00
Member
Copy Link

We should probably have debug off or control it with ENV for production.

We should probably have debug off or control it with ENV for production.
s marked this conversation as resolved
src/hooks/useNDK.ts Outdated
@ -0,0 +457,4 @@
const ndkRelayList = await getNDKRelayList(receiver)
const readRelayUrls = [...ndkRelayList.readRelayUrls]
enes commented 2024-12-30 12:04:07 +00:00
Member
Copy Link

Had this error after completing a sigit (error types here don't indicate undefined to be a possibility) and after timestamp upgrades triggered.

TypeError: Cannot read properties of undefined (reading 'readRelayUrls')
    at useNDK.ts:460:46
    at async Promise.all (:5173/index 0)
    at async upgradeT (index.tsx:383:11)```
Had this error after completing a sigit (error types here don't indicate `undefined` to be a possibility) and after timestamp upgrades triggered. ``` TypeError: Cannot read properties of undefined (reading 'readRelayUrls') at useNDK.ts:460:46 at async Promise.all (:5173/index 0) at async upgradeT (index.tsx:383:11)```
s commented 2025-01-04 06:46:57 +00:00
Author
Owner
Copy Link

I tried multiple sigit rounds, but couldn't reproduce this issue.

I tried multiple sigit rounds, but couldn't reproduce this issue.
src/store/user/reducer.ts Outdated
@ -0,0 +23,4 @@
profile: action.payload
}
// case ActionTypes.RESTORE_STATE:
enes commented 2024-12-30 11:42:43 +00:00
Member
Copy Link

Are we intentionally skipping restoration of the user state?

Are we intentionally skipping restoration of the user state?
s commented 2025-01-04 06:37:15 +00:00
Author
Owner
Copy Link

It wasn't intentional, fixed

It wasn't intentional, fixed
s marked this conversation as resolved
s added 2 commits 2025-01-04 06:26:36 +00:00
s added 1 commit 2025-01-04 06:34:01 +00:00
chore: enable debug logs only in dev mode
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 41s
Details
0d93e16f3a
s added 1 commit 2025-01-04 07:21:55 +00:00
chore: merge staging into use-ndk
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 44s
Details
14c103dd40
s added 1 commit 2025-01-06 11:05:06 +00:00
chore: quick fixes
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 44s
Details
48f85f54c8
s merged commit 60b3a28435 into staging 2025-01-06 11:10:49 +00:00
s deleted branch use-ndk 2025-01-06 11:10:50 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#283
No description provided.
Delete Branch "use-ndk"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?