sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

Refactor create page interactions and fix the "excel" bug #284

Merged
b merged 8 commits from 282-create-page-interactions into staging 2024-12-23 10:47:27 +00:00
Conversation 1 Commits 8 Files Changed 11 +542 -351
enes commented 2024-12-23 10:18:24 +00:00
Member
Copy Link
  • Use simpler code to add dividers to the dynamic file items
  • Introduce "immer" package for state management (updating complex and deeply nested states is easier - sigitFiles)
  • Add DrawPDFFields internal components:
    • add Image and File items
    • add Counterpart
  • Bump z-index of the spinner to accommodate new tmp. drawing rect
  • Optimize events and responsiveness across the board for the create page drawing (use callbacks and less sigitfiles state updates)
  • Fix the issue which caused refresh to bring back the "previous" selection of files, the files from location.state (home page uploaded) would override the newly added or removed (create page uploaded)

Closes #282

- Use simpler code to add dividers to the dynamic file items - Introduce "immer" package for state management (updating complex and deeply nested states is easier - *sigitFiles*) - Add DrawPDFFields internal components: - add Image and File items - add Counterpart - Bump z-index of the spinner to accommodate new tmp. drawing rect - Optimize events and responsiveness across the board for the create page drawing (use callbacks and less sigitfiles state updates) - Fix the issue which caused refresh to bring back the "previous" selection of files, the files from `location.state` (home page uploaded) would override the newly added or removed (create page uploaded) Closes #282
enes added 8 commits 2024-12-23 10:18:25 +00:00
refactor(create): update location state to keep latest selected files
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 43s
Details
1827a20755
enes requested review from m 2024-12-23 10:19:08 +00:00
m approved these changes 2024-12-23 10:42:40 +00:00
b merged commit a5e31b0bdf into staging 2024-12-23 10:47:27 +00:00
b deleted branch 282-create-page-interactions 2024-12-23 10:47:28 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
m
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#284
No description provided.
Delete Branch "282-create-page-interactions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?