sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

fix: Opening a sigit asks you to sign when you are not the next signer #285

Merged
b merged 4 commits from issue-281 into staging 2024-12-24 10:02:36 +00:00
Conversation 2 Commits 4 Files Changed 2 +12 -5
m commented 2024-12-23 12:58:21 +00:00
Owner
Copy Link

Closes #281

Closes #281
m added 1 commit 2024-12-23 12:58:21 +00:00
fix: Opening a sigit asks you to sign when you are not the next signer
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 46s
Details
ae3d461661
enes commented 2024-12-23 13:15:24 +00:00
Member
Copy Link

Found an issue, navigate after publish also leads to sign even if creator is not 1st signer, steps to reproduce:

  1. Create a sigit
  2. Add a signer
  3. Swap the places of creator and new signer
  • creator now signs second and new signer is first
  1. Publish
  • navigate leads to sign where the input is presented to the creator, even though he should be the 2nd signer

Going back manually and clicking sigit gives the correct state and leads to verify page as a creator.

Found an issue, navigate after publish also leads to sign even if creator is not 1st signer, steps to reproduce: 1. Create a sigit 2. Add a signer 3. Swap the places of creator and new signer - creator now signs second and new signer is first 4. Publish - navigate leads to sign where the input is presented to the creator, even though he should be the 2nd signer Going back manually and clicking sigit gives the correct state and leads to verify page as a creator.
b added 1 commit 2024-12-23 17:33:01 +00:00
Merge branch 'staging' into issue-281
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 46s
Details
8000f4a349
m added 2 commits 2024-12-24 09:59:06 +00:00
chore(git): merge
All checks were successful
Open PR on Staging / audit_and_check (pull_request) Successful in 39s
Details
a2b7423c8b
enes approved these changes 2024-12-24 10:01:59 +00:00
b merged commit 1909534079 into staging 2024-12-24 10:02:36 +00:00
b deleted branch issue-281 2024-12-24 10:02:36 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
enes
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#285
No description provided.
Delete Branch "issue-281"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?