sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases 5 Wiki Activity

Placeholder avatar is incosistent across components #39

Merged
s merged 9 commits from issue-27 into main 2024-05-16 08:58:11 +00:00
Conversation 3 Commits 9 Files Changed 5 +33 -16
m commented 2024-05-15 11:15:28 +00:00
Owner
Copy Link

Closes #27

Closes #27
m added 1 commit 2024-05-15 11:15:28 +00:00
m added 1 commit 2024-05-15 11:58:04 +00:00
b added 1 commit 2024-05-15 12:27:26 +00:00
y requested changes 2024-05-15 12:36:58 +00:00
y left a comment
Owner
Copy Link

To make the avatar consistent, please put image URL into app state and subscribe to its changes.

To make the avatar consistent, please put image URL into app state and subscribe to its changes.
s reviewed 2024-05-15 13:26:47 +00:00
src/utils/nostr.ts Outdated
@ -139,2 +140,4 @@
}
}
export const getRoboHashPicture = (npub: string): string => {
s commented 2024-05-15 13:26:47 +00:00
Owner
Copy Link

Allow this to accept both npub and hex, If provided value is not npub then convert it to npub

Allow this to accept both npub and hex, If provided value is not npub then convert it to npub
m marked this conversation as resolved
m added 1 commit 2024-05-16 06:55:30 +00:00
m added 1 commit 2024-05-16 07:13:56 +00:00
m added 1 commit 2024-05-16 07:23:25 +00:00
m added 1 commit 2024-05-16 07:25:20 +00:00
m added 1 commit 2024-05-16 08:26:35 +00:00
s requested changes 2024-05-16 08:54:17 +00:00
src/controllers/AuthController.ts Outdated
@ -53,4 +43,0 @@
const signedAuthEvent = await this.nostrController.signEvent(authEvent)
this.createAndSaveAuthToken(signedAuthEvent)
s commented 2024-05-16 08:47:48 +00:00
Owner
Copy Link

removal of this code will allow you to login as any user. Just enter npub/nip05 and you'll be logged in as that user.

removal of this code will allow you to login as any user. Just enter npub/nip05 and you'll be logged in as that user.
m marked this conversation as resolved
m added 1 commit 2024-05-16 08:56:14 +00:00
s merged commit fe58ccd343 into main 2024-05-16 08:58:11 +00:00
s deleted branch issue-27 2024-05-16 08:58:11 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
y
s
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#39
No description provided.
Delete Branch "issue-27"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?