sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases 5 Wiki Activity

Profile pictures incosistencies #58

Merged
b merged 7 commits from pictures-fixes into main 2024-05-17 11:52:36 +00:00
Conversation 2 Commits 7 Files Changed 13 +130 -60
m commented 2024-05-17 11:33:34 +00:00
Owner
Copy Link

Closes #46

Closes #46
m added 3 commits 2024-05-17 11:33:34 +00:00
m added 2 commits 2024-05-17 11:35:42 +00:00
m added 1 commit 2024-05-17 11:41:07 +00:00
y approved these changes 2024-05-17 11:44:34 +00:00
Dismissed
src/components/AppBar/AppBar.tsx
@ -87,3 +89,3 @@
)
dispatch(setMetadataEvent(metadataController.getEmptyMetadataEvent()))
dispatch(setUserRobotImage(null))
y commented 2024-05-17 11:40:19 +00:00
Owner
Copy Link

the app will clear local storage on logout anyway

the app will clear local storage on logout anyway
m commented 2024-05-17 11:47:49 +00:00
Author
Owner
Copy Link

This is a redux bit, won't get cleared automatically.

This is a redux bit, won't get cleared automatically.
m marked this conversation as resolved
src/store/userRobotImage/reducer.ts Outdated
@ -0,0 +12,4 @@
return action.payload
case ActionTypes.RESTORE_STATE:
return action.payload.userRobotImage || null
y commented 2024-05-17 11:44:15 +00:00
Owner
Copy Link

|| null is not needed in such case

`|| null` is not needed in such case
m marked this conversation as resolved
m added 1 commit 2024-05-17 11:49:28 +00:00
y approved these changes 2024-05-17 11:52:13 +00:00
b merged commit f7723a3ee9 into main 2024-05-17 11:52:36 +00:00
b deleted branch pictures-fixes 2024-05-17 11:52:36 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
y
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#58
No description provided.
Delete Branch "pictures-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?