sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

feat(Relays): added logic to manage relays #63

Closed
y wants to merge 8 commits from relays-management into main
pull from: relays-management
merge into: sigit:main
Conversation 2 Commits 8 Files Changed 23 +1497 -27
y commented 2024-05-21 05:21:10 +00:00
Owner
Copy Link

Issue

Closes #38

Intent

  • Add a Relays page in order to manage user's relays.

Implementation

  • Added relays page to src/pages/relays/index.tsx.
  • Added relays state to src/store/relays.
  • Improved authAndGetMetadataAndRelaysMap method of AuthController to also get relay map.
  • Added getRelayMap and publishRelayMap methods to NostrController.
  • Added useAppDispatch and useAppSelector hooks to src/hooks/store.ts.
  • Added compareObjects utility to src/utils/utils.ts.
## Issue Closes #38 ## Intent - Add a `Relays` page in order to manage user's relays. ## Implementation - Added relays page to `src/pages/relays/index.tsx`. - Added relays state to `src/store/relays`. - Improved `authAndGetMetadataAndRelaysMap` method of `AuthController` to also get relay map. - Added `getRelayMap` and `publishRelayMap` methods to `NostrController`. - Added `useAppDispatch` and `useAppSelector` hooks to `src/hooks/store.ts`. - Added `compareObjects` utility to `src/utils/utils.ts`.
y added 1 commit 2024-05-21 05:21:11 +00:00
s approved these changes 2024-05-21 06:20:41 +00:00
m approved these changes 2024-05-21 06:38:26 +00:00
src/controllers/NostrController.ts Outdated
@ -377,0 +391,4 @@
npub: string
): Promise<{ map: RelayMap; mapUpdated: number }> => {
const mostPopularRelays = import.meta.env.VITE_MOST_POPULAR_RELAYS
const hardcodedPopularRelays = (mostPopularRelays || '').split(' ')
m commented 2024-05-21 06:23:44 +00:00
Owner
Copy Link

Does this mean we will not use a https://stats.nostr.band/stats_api?method=stats service to fetch most popular relays?

Does this mean we will not use a https://stats.nostr.band/stats_api?method=stats service to fetch most popular relays?
y commented 2024-05-21 06:42:08 +00:00
Author
Owner
Copy Link

do we already use such an approach to fetch relays?
In the MetadataController we also use env.

do we already use such an approach to fetch relays? In the `MetadataController` we also use env.
m commented 2024-05-21 06:48:30 +00:00
Owner
Copy Link

We do have in the other project, sending you link in the DM

We do have in the other project, sending you link in the DM
src/pages/relays/index.tsx
@ -0,0 +205,4 @@
<Box className={styles.relaysContainer}>
{Object.keys(relayMap).map((relay, i) => (
<Box className={styles.relay} key={`relay_${i}`}>
<List>
m commented 2024-05-21 06:33:51 +00:00
Owner
Copy Link

I suggest implementing an indication (green/red dot) if the relay actually works. Because relay can be:

  • Unreachable (down)
  • Requiring payment

image example

I suggest implementing an indication (green/red dot) if the relay actually works. Because relay can be: - Unreachable (down) - Requiring payment ![image example](https://paste.4gl.io/?b27a689748f5d0e4#FPrJLQbXDrKv3CAZ7iaYEma4cKgTNGihXEpWprFdWvhw)
👍 2
y commented 2024-05-21 06:45:53 +00:00
Author
Owner
Copy Link

Good suggestion!
I think we should implement this feature later as it feels like nice to have, but is not crucial.

Good suggestion! I think we should implement this feature later as it feels like nice to have, but is not crucial.
y added 6 commits 2024-05-24 12:57:10 +00:00
y added 1 commit 2024-05-24 13:05:57 +00:00
y closed this pull request 2024-05-24 13:13:52 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
s
m
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#63
No description provided.
Delete Branch "relays-management"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?