sigit/sigit.io
7
2
Fork 0
Code Issues 32 Pull Requests 2 Actions Packages Projects 1 Releases Wiki Activity

feat: added profile view #64

Merged
y merged 6 commits from issue-43 into main 2024-05-22 09:11:59 +00:00
Conversation 5 Commits 6 Files Changed 8 +677 -245
m commented 2024-05-21 07:08:30 +00:00
Owner
Copy Link

Closes #43

Screenshot

image

Todo

  • Add banner, refactor other elements to accommodate banner
  • Confirm LNURL is shown when populated
  • Key should be displayed as NPUB not HEX
Closes #43 ## Screenshot ![image](/attachments/bfd4adcb-a95b-4d4c-9b6e-7112a4f8cc5d) ## Todo - [x] Add banner, refactor other elements to accommodate banner - [x] Confirm LNURL is shown when populated - [x] Key should be displayed as NPUB not HEX
image.png
354 KiB
image.png
354 KiB
image.png
m added 1 commit 2024-05-21 07:08:30 +00:00
m added 1 commit 2024-05-21 08:09:31 +00:00
y commented 2024-05-21 10:07:36 +00:00
Owner
Copy Link

Please change npub from hex format to npub....
Please decrease the space between the lines to make profile info more compact.
Please increase the profile image to take all the space up to about section.

Please change npub from hex format to `npub...`. Please decrease the space between the lines to make profile info more compact. Please increase the profile image to take all the space up to about section.
m commented 2024-05-21 12:21:36 +00:00
Author
Owner
Copy Link

Please change npub from hex format to npub....
Please decrease the space between the lines to make profile info more compact.
Please increase the profile image to take all the space up to about section.

Can you please provide new feedback since I changed design quite a bit?

> Please change npub from hex format to `npub...`. > Please decrease the space between the lines to make profile info more compact. > Please increase the profile image to take all the space up to about section. Can you please provide new feedback since I changed design quite a bit?
y commented 2024-05-21 12:28:26 +00:00
Owner
Copy Link

Please change npub from hex format to npub....
Please decrease the space between the lines to make profile info more compact.
Please increase the profile image to take all the space up to about section.

Can you please provide new feedback since I changed design quite a bit?

Well done!
Please also reduce the amount of space between lines and icons should be centered on the corresponding line.
I would also use the same font style for the link as you did for npub (please use npub... format) and put link icon to the right.

> > Please change npub from hex format to `npub...`. > > Please decrease the space between the lines to make profile info more compact. > > Please increase the profile image to take all the space up to about section. > > Can you please provide new feedback since I changed design quite a bit? Well done! Please also reduce the amount of space between lines and icons should be centered on the corresponding line. I would also use the same font style for the link as you did for npub (please use `npub...` format) and put link icon to the right.
m added 1 commit 2024-05-21 13:21:14 +00:00
m added 1 commit 2024-05-21 13:21:27 +00:00
m requested review from y 2024-05-21 13:22:15 +00:00
y commented 2024-05-22 08:49:26 +00:00
Owner
Copy Link

@m , please use 15 as shorten offset as we have plenty of space

@m , please use 15 as shorten offset as we have plenty of space
m added 1 commit 2024-05-22 09:09:47 +00:00
m added 1 commit 2024-05-22 09:11:26 +00:00
y approved these changes 2024-05-22 09:11:43 +00:00
y merged commit bb28e47ff9 into main 2024-05-22 09:11:59 +00:00
y deleted branch issue-43 2024-05-22 09:11:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
y
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sigit/sigit.io#64
No description provided.
Delete Branch "issue-43"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?